WebApps: Websites integration Firefox plug-in

  1. Bug #1040313
  2. Comment #9

Comment 9 for bug 1040313

Revision history for this message
In , Roc-ocallahan (roc-ocallahan) wrote :

Comment on attachment 637885
Adds JS nativeHandler attribute for nsIBaseWindow

Review of attachment 637885:
-----------------------------------------------------------------

::: widget/nsIBaseWindow.idl
@@ +163,5 @@
> +
> + @throws NS_ERROR_NOT_IMPLEMENTED for non-toplevel widgets, or
> + NS_ERROR_UNEXPECTED if conversion fails
> + */
> + [implicit_jscontext] readonly attribute jsval nativeHandle;

Why not declare it as a DOMString instead of a jsval?