valide r557 segfaults at configure/build

[Christian González]

* get bzr r557
* ./waf configure
* ./waf build
* sudo ./waf install
* sudo ldconfig
* valide
* -> open the project valide.vide
* Menu "Project" -> "configure F5"

-> Segmentation fault

[Christian González (droetker)]

additional gdb info:

[...]
builder.vala:254: creating object of type `ValideSource'
builder.vala:254: creating object of type `ValideSource'
builder.vala:254: creating object of type `ValideSource'
builder.vala:254: creating object of type `ValideSource'
builder.vala:254: creating object of type `ValideSource'
[New Thread 0x7fffe8e92710 (LWP 3939)]

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff6c62253 in gdk_color_copy () from /usr/lib/libgdk-x11-2.0.so.0

[Nicolas Joseph (gege2061)]

Can you retry with the latest revision? I can't reproduce this bug.

[Monkey (monkey-libre)]

valide crash when I try to build valide project frhom Project menu (F6) (valide trunk with vala 0.11.5)

[Monkey (monkey-libre)]

Here the crash log.
Do not hesitate to ask for more info.

[Monkey (monkey-libre)]

I think, the problem appears when the _build_ folder exist with root permissions, i.e when you build valide from terminal with root.
Review the branch before I proposal a merge (vala 0.11.5 is required but is not applied in trunk)

[Nicolas Joseph (gege2061)]

> vala 0.11.5 is required but is not applied in trunk

I've forgotten, sorry.

- this.list_store.set (iter, Col.TEXT, l, Col.COLOR, color);
+ this.list_store.set (iter, Col.TEXT, l, Col.COLOR, color, -1);

This patch fix the problem with directory permission? It's very strange...

[Nicolas Joseph (gege2061)]

On Debian x86 the permission error is correctly catch.

[Monkey (monkey-libre)]

valide doesn´t crash when try to show that with the patch unless for me.
I´ll check the last trunk.

[Nicolas Joseph (gege2061)]

The C code is functionally unchanged:

- gtk_list_store_set (self->priv->list_store, &iter, VALIDE_EXECUTABLE_MANAGER_COL_TEXT, l, VALIDE_EXECUTABLE_MANAGER_COL_COLOR, &color, -1);
+ gtk_list_store_set (self->priv->list_store, &iter, VALIDE_EXECUTABLE_MANAGER_COL_TEXT, l, VALIDE_EXECUTABLE_MANAGER_COL_COLOR, &color, -1, -1);

If this patch fix this bug, it's probably a bad patch. In trunk, I have fixed a problem with index_of evaluation (r582) can be cause an miss-assigned color variable. This is a more likely cause of segfault, but I don't not really know.

[Monkey (monkey-libre)]

Now I can´t reproduce with/withouth -1. I added it by:
(valide:2159): Gtk-WARNING **: /build/buildd/gtk+2.0-2.20.1/gtk/gtkliststore.c:797: Invalid column number -1499064039 added to iter (remember to end your list of columns with a -1)

Perhaps it was a config problem?

[Nicolas Joseph (gege2061)]

Can you post the backtrace since this warning by using G_DEBUG="fatal-warnings"?

[Monkey (monkey-libre)]

I get this warning every time I try to open a project. The other warning I can not reproduce by now.

[Nicolas Joseph (gege2061)]

warning removed!

[Monkey (monkey-libre)]

Now it´s working fine, withouth warnings.
Thanks a lot.

P.S: default templates have deprecated code, but this week and next I won´t have free time for updating them.

[Nicolas Joseph (gege2061)]

I fixed the warning about the property path, not the gtk warning in #10

[Monkey (monkey-libre)]

other fail-warning [1] like the last [2]. Fresh Ubuntu 11.04 (alpha2) and with a fresh valide trunk.

[1] GLib-GObject-WARNING **: g_object_set_property: property `path' of object class `ValideProject' is not writable

[2] GLib-GObject-WARNING **: IA__g_object_set_property: property `path' of object class `ValideProject' is not writable

[Nicolas Joseph (gege2061)]

@Monkey: the bug was in the writer. Check if your valide.vide file doesn't contain a path property and you can try again.

[Monkey (monkey-libre)]

Sorry for the noise, now I don´t get any warning with trunk