Category header links don't work in overview

Bug #1356410 reported by Scott Sweeny
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity8 (Ubuntu)
Fix Released
Critical
Marcus Tomlinson
unity8 (Ubuntu RTM)
Fix Released
Undecided
Unassigned

Bug Description

Tapping on category header links in non-favorited scopes does nothing, while on favorited scopes it opens the respective query.

To reproduce:
 * Open Music scope
 * click "Popular tracks on Grooveshark" header, observe that the grooveshark scope is opened.
 * Edit /usr/share/upstart/sessions/unity8-dash.conf
 * remove "musicaggregator" from the UNITY_SCOPES_LIST line
 * reboot the phone
 * Open the music scope from the Dash Manager
 * Click "Popular tracks on Grooveshark" header, observe that nothing happens.

Tags: rtm14

Related branches

Michał Sawicz (saviq)
Changed in unity8:
status: New → Triaged
importance: Undecided → Critical
tags: added: rtm14
Revision history for this message
Michał Sawicz (saviq) wrote :

Right, the linked scope probably opens "under" the overview. Need to fix that.

summary: - Category header links broken on non-favorited scopes
+ Category header links in overview
summary: - Category header links in overview
+ Category header links don't work in overview
Changed in unity8:
assignee: nobody → Marcus Tomlinson (marcustomlinson)
Changed in unity8:
status: Triaged → In Progress
Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

"tempScopeItem" (GenericScopeView) in ScopesOverview.qml was not handling the onOpenScope signal (as is done with "scopeItem" in Dash.qml).

I've added a signal handler for this but one issue still remains: when activating the link, the scope is immediately replaced without animation. This is a known issue, but independent of this bug.

Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
status: New → In Progress
Changed in unity8 (Ubuntu RTM):
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.00+14.10.20140827.2-0ubuntu1

---------------
unity8 (8.00+14.10.20140827.2-0ubuntu1) utopic; urgency=low

  [ Michał Sawicz ]
  * Implement scope header customization options
  * Don't ignore empty attributes in CardAttributes.qml and improve its
    encapsulation (LP: #1355901)
  * Add support for preview button color customization. Deprecate
    support for action icons.
  * Add table preview widget
  * Make "See Less" get stuck at the bottom of the view
  * Support alternative navigation in the dash.
  * Add scope settings UI
  * Add scope favoriting support
  * Passcode, not PIN (LP: #1361114)

  [ Jussi Pakkanen ]
  * Use nullptr instead of NULL.

  [ Albert Astals ]
  * Add table preview widget
  * Make "See Less" get stuck at the bottom of the view
  * Support alternative navigation in the dash.
  * Make the PageHeaderLabelTest pass under valgrind

  [ Benjamin Zeller ]
  * Add support for scope:// url in the dash (LP: #1361349)

  [ Marcus Tomlinson ]
  * Handle the openScope signal in "tempScopeItem" (ScopesOverview.qml)
    as is done with "scopeItem" (Dash.qml) (LP: #1356410)

  [ Daniel d'Andrada ]
  * Make "See Less" get stuck at the bottom of the view

  [ Andrea Cimitan ]
  * Fix right padding on overlay card
  * Add scope settings UI

  [ Michael Zanetti ]
  * use a smaller asset for the app's dropshadow (LP: #1359157)
 -- Ubuntu daily release <email address hidden> Wed, 27 Aug 2014 15:37:05 +0000

Changed in unity8 (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.00+14.10.20140827.2-0ubuntu1

---------------
unity8 (8.00+14.10.20140827.2-0ubuntu1) 14.09; urgency=low

  [ Michał Sawicz ]
  * Implement scope header customization options
  * Don't ignore empty attributes in CardAttributes.qml and improve its
    encapsulation (LP: #1355901)
  * Add support for preview button color customization. Deprecate
    support for action icons.
  * Add table preview widget
  * Make "See Less" get stuck at the bottom of the view
  * Support alternative navigation in the dash.
  * Add scope settings UI
  * Add scope favoriting support
  * Passcode, not PIN (LP: #1361114)

  [ Jussi Pakkanen ]
  * Use nullptr instead of NULL.

  [ Albert Astals ]
  * Add table preview widget
  * Make "See Less" get stuck at the bottom of the view
  * Support alternative navigation in the dash.
  * Make the PageHeaderLabelTest pass under valgrind

  [ Benjamin Zeller ]
  * Add support for scope:// url in the dash (LP: #1361349)

  [ Marcus Tomlinson ]
  * Handle the openScope signal in "tempScopeItem" (ScopesOverview.qml)
    as is done with "scopeItem" (Dash.qml) (LP: #1356410)

  [ Daniel d'Andrada ]
  * Make "See Less" get stuck at the bottom of the view

  [ Andrea Cimitan ]
  * Fix right padding on overlay card
  * Add scope settings UI

  [ Michael Zanetti ]
  * use a smaller asset for the app's dropshadow (LP: #1359157)
 -- Ubuntu daily release <email address hidden> Wed, 27 Aug 2014 15:37:05 +0000

Changed in unity8 (Ubuntu RTM):
status: In Progress → Fix Released
Michał Sawicz (saviq)
Changed in unity8:
status: In Progress → Fix Committed
status: Fix Committed → Fix Released
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
assignee: nobody → Marcus Tomlinson (marcustomlinson)
importance: Undecided → Critical
no longer affects: unity8
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.