ResultIterator.h defines functions that return const values
Bug #1163705 reported by
Michi Henning
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Unity | Status tracked in Trunk | |||||
6.0 |
Won't Fix
|
Undecided
|
Unity Team | |||
7.0 |
Won't Fix
|
Undecided
|
Unity Team | |||
Phablet-mods |
Fix Committed
|
Undecided
|
Unity Team | |||
Trunk |
Fix Released
|
Undecided
|
Unity Team | |||
unity (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
In UnityCore/
friend inline bool const operator<(const ResultIterator& lhs, const ResultIterator& rhs)
and
bool const IsLast();
Declaring a function to return a const value is meaningless, and the compiler ignores the const. Moreover, with -Wall -Wextra, gcc emits a warning about the ignored const and, with -Werror, produces an error.
The const return values need to be non-const.
Related branches
lp:~michihenning/unity/ResultIterator-1163705
- PS Jenkins bot (community): Approve (continuous-integration)
- Unity Team: Pending requested
-
Diff: 67 lines (+9/-9)2 files modifiedUnityCore/ResultIterator.cpp (+2/-2)
UnityCore/ResultIterator.h (+7/-7)
Changed in unity: | |
assignee: | nobody → Michi Henning (michihenning) |
status: | New → In Progress |
no longer affects: | unity/phablet |
To post a comment you must log in.
Fix committed into lp:unity at revision None, scheduled for release in unity, milestone backlog