Dash - Shape and positioning of most of the elements in the Dash need adjustment (Part 3)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Released
|
Critical
|
John Lea | ||
Unity |
Fix Released
|
Medium
|
Gord Allott | ||
unity (Ubuntu) |
Fix Released
|
Medium
|
Unassigned |
Bug Description
The shape and positioning of most of the elements in the Dash need adjustment. There are many many of these very small adjustment issues, so rather then open 25+ separate bugs they are listed as bulletpoints.
Before reading the list, open the following image: https:/
In this image the signed off design is laid on top of the current implementation with 80% opacity. Look at where elements are placed relative to where they should be placed according to the design, and also look at the different shape of elements compared to the design.
When fixing these issues, keep taking screenshots of the implementation and matching them up to the design (as done with the Dash_layout.png) to check how the layout is progressing. When this process stops showing variations this bug is resolved ;-)
-------
List of positioning issues:
- The Category Headers are positioned wrong (too far right, too low)
- The search box is positioned wrong (centre should align with the center of the BFB, should start a few px to the left)
- There is too much space between the individual icons in the search result
- There is too much space below each category header
- The desktop dash box is much too large (both height and width)
- "Filter results" header is positioned wrong (should be right and slightly up)
- The individual search filter category titles and the "All" button is too high relative to the other filter buttons
-------
List of shape issues:
- The font size of category header titles is too large
- the spacing between the search result icons is too large
- "Filter results" is the wrong font size and weight
- The 'rating' stars are the wrong size
- the dividers in between the filter results categories are missing
- the 'All' button's shape is too narrow and too high (should be the same height as the other filter buttons)
Related branches
- Mirco Müller (community): Approve
-
Diff: 198 lines (+39/-28)8 files modifiedplugins/unityshell/src/DashSearchBar.cpp (+1/-1)
plugins/unityshell/src/DashView.cpp (+7/-3)
plugins/unityshell/src/PlacesGroup.cpp (+22/-16)
plugins/unityshell/src/PlacesGroup.h (+1/-0)
plugins/unityshell/src/PlacesStyle.cpp (+3/-2)
plugins/unityshell/src/ResultRendererTile.cpp (+2/-3)
plugins/unityshell/src/ResultViewGrid.cpp (+1/-1)
tests/standalone_dash.cpp (+2/-2)
tags: | added: onew udo |
Changed in ayatana-design: | |
assignee: | nobody → John Lea (johnlea) |
importance: | Undecided → Critical |
status: | New → Fix Committed |
Changed in unity: | |
assignee: | nobody → Gord Allott (gordallott) |
importance: | Undecided → Medium |
status: | New → Triaged |
milestone: | none → 4.18.0 |
Changed in unity: | |
status: | Triaged → Fix Committed |
Changed in unity (Ubuntu): | |
status: | Triaged → Fix Committed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
@John: does your bug include this? https:/ /bugs.launchpad .net/unity/ +bug/851066