Dash - the "Decade" and "Size" dash filter category widgets are broken
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Released
|
High
|
John Lea | ||
Unity |
Fix Released
|
High
|
Nick Dedekind | ||
unity (Ubuntu) |
Fix Released
|
High
|
Nick Dedekind |
Bug Description
There are a number of issues with the"Decade" and "Size" dash filter category widgets.
As this widget follows the same design pattern as used by the musicovery.com decade filter, the first step to understanding these issues is to have a good play with the musicovery.com implementation. To find this widget in musicovery.com, click on anything inside the mood box on the home page (e.g. the word 'dark') and then look at the decade range filter that is then presented underneath the mood box. Specifically examine how this widget responds to both cursor drag and click interactions.
Desired Resolution:
- Implement drag interactions.
1) Dragging from a selected segment to a non-selected segment increases the selected range.
| |###|###|###| | | - pointer over item, button pressed
^
| |###|###|###|###| | - pointer dragged 1 to the right with button pressed
^
2) Dragging from the selected segments at the far left or right of the range back over other selected segments, deselects the segments the pointer passes over (but not the segment the pointer is over at the moment the left button is released)
| |###|###|###|###| | - selection before user interaction
| |###|###|###|###| | - pointer over last item, button pressed
^
| |###|###|###| | | - pointer dragged 1 to the left with button pressed
^
- Correct the height of this widget to match the design
- Correct the corner radius of this widget to match the design.
- Correct the click interactions. Clicking on a item in the range should select only that item, and deselect all other items.
Nick Dedekind - Split into new bug https:/
- Remove the ellipsising ("...") of filters too long to fit into their box. Each notch's box only needs to be length of it's label (they don't all need to be the same width). See the visual design.
Refer to the visual designs that are available @ https:/
Related branches
- Andrea Azzarone (community): Approve
- John Lea (community): Approve
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 1508 lines (+825/-185)20 files modifiedUnityCore/MultiRangeFilter.cpp (+42/-52)
dash/FilterAllButton.cpp (+2/-0)
dash/FilterAllButton.h (+1/-0)
dash/FilterBasicButton.cpp (+2/-0)
dash/FilterBasicButton.h (+1/-0)
dash/FilterFactory.cpp (+1/-1)
dash/FilterGenreButton.cpp (+2/-0)
dash/FilterGenreButton.h (+1/-0)
dash/FilterMultiRangeButton.cpp (+22/-17)
dash/FilterMultiRangeButton.h (+2/-1)
dash/FilterMultiRangeWidget.cpp (+243/-26)
dash/FilterMultiRangeWidget.h (+24/-5)
dash/FilterRatingsButton.cpp (+3/-0)
dash/FilterRatingsButton.h (+1/-0)
tests/CMakeLists.txt (+1/-0)
tests/test_filter_multirange.h (+75/-0)
tests/test_filter_widgets.cpp (+187/-0)
tests/test_lens.cpp (+12/-17)
unity-shared/DashStyle.cpp (+202/-66)
unity-shared/DashStyle.h (+1/-0)
description: | updated |
tags: | added: onew udo |
Changed in ayatana-design: | |
assignee: | nobody → John Lea (johnlea) |
importance: | Undecided → Critical |
status: | New → Fix Committed |
description: | updated |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
Changed in unity: | |
importance: | Undecided → Medium |
status: | New → Triaged |
Changed in unity (Ubuntu): | |
importance: | Undecided → Medium |
status: | New → Triaged |
Changed in unity: | |
assignee: | nobody → Gord Allott (gordallott) |
Changed in unity (Ubuntu): | |
assignee: | nobody → Gord Allott (gordallott) |
tags: | added: udp |
Changed in unity: | |
milestone: | none → backlog |
Changed in ayatana-design: | |
status: | Fix Released → Fix Committed |
tags: |
added: unity3p removed: unity-3p |
Changed in ayatana-design: | |
importance: | Critical → High |
tags: | added: euv |
Changed in unity: | |
importance: | Medium → High |
Changed in unity (Ubuntu): | |
importance: | Medium → High |
Changed in unity: | |
milestone: | backlog → none |
tags: | added: exbacklog |
Changed in unity: | |
assignee: | Gord Allott (gordallott) → nobody |
Changed in unity (Ubuntu): | |
assignee: | Gord Allott (gordallott) → nobody |
Changed in unity: | |
assignee: | nobody → Nick Dedekind (nick-dedekind) |
description: | updated |
Changed in unity: | |
status: | Triaged → In Progress |
Changed in unity: | |
milestone: | none → 7.0.0 |
Changed in unity (Ubuntu): | |
assignee: | nobody → Nick Dedekind (nick-dedekind) |
Changed in unity (Ubuntu): | |
status: | Triaged → In Progress |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
Extension of this bug (related to visual pixel perfection), here: /bugs.launchpad .net/unity/ +bug/897627
https:/