Window buttons in the panel have no indication of the "pressed" form
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
Low
|
Marco Trevisan (Treviño) | ||
unity (Ubuntu) |
Fix Released
|
Low
|
Marco Trevisan (Treviño) |
Bug Description
There should be 3 different types of icons in the windows buttons at the top left corner when windows are maximized:
- Normal icon
- When mouse over
- When mouse over & Pressing
This works on non-maximized windows but it doesn't on maximized windows, steps to reproduce:
1. Move mouse to one of the buttons on the top left corner, say minimize button
2. The icon should be lighter
3. Press the left button (HOLD IT!), the icon doesn't change to "pressed", but maintains lighted
4. Drag the mouse (Still holding it!) out of the button, let's say to the frame you have opened, so move it down
5. The minimize button icon moves to type "Pressed"
The button should change to type "Pressed" when it has the mouse inside it AND the user is pressing the button. Attached is a video.
Also, I have fixed the Unity code for this, but in order to commit the code I need to make sure it's not just me.
Related branches
- Neil J. Patel (community): Approve
-
Diff: 12 lines (+1/-1)1 file modifiedplugins/unityshell/src/WindowButtons.cpp (+1/-1)
- Neil J. Patel (community): Approve
- Jason Smith (community): Approve
- Gord Allott (community): Approve
-
Diff: 1499 lines (+470/-231)12 files modifiedplugins/unityshell/src/PanelIndicatorsView.cpp (+55/-41)
plugins/unityshell/src/PanelIndicatorsView.h (+13/-1)
plugins/unityshell/src/PanelMenuView.cpp (+146/-86)
plugins/unityshell/src/PanelMenuView.h (+9/-7)
plugins/unityshell/src/PanelTitlebarGrabAreaView.cpp (+35/-33)
plugins/unityshell/src/PanelTitlebarGrabAreaView.h (+11/-10)
plugins/unityshell/src/PanelView.cpp (+20/-9)
plugins/unityshell/src/PanelView.h (+3/-0)
plugins/unityshell/src/PluginAdapter.cpp (+33/-1)
plugins/unityshell/src/WindowButtons.cpp (+14/-2)
plugins/unityshell/src/WindowManager.cpp (+5/-1)
services/panel-service.c (+126/-40)
Changed in unity: | |
status: | Confirmed → In Progress |
Changed in unity (Ubuntu): | |
status: | New → In Progress |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity (Ubuntu): | |
status: | In Progress → Fix Committed |
status: | Fix Committed → Confirmed |
status: | Confirmed → In Progress |
summary: |
- Unity windows buttons icons and clicking them not matching + Window buttons in the panel have no indication of the "pressed" form |
Changed in unity: | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
Changed in unity (Ubuntu): | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
Changed in unity: | |
status: | Confirmed → In Progress |
Changed in unity (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in unity: | |
milestone: | none → 4.18.0 |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Now its confirmed please propose the fix ;)