Unity crashes when dynamic quicklist dbusmenu contains a hidden menuitem.

Bug #759174 reported by Bilal Akhtar
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Unity
Fix Released
Medium
Bilal Akhtar
unity (Ubuntu)
Fix Released
Medium
Bilal Akhtar
Natty
Fix Released
Undecided
Unassigned

Bug Description

If the dynamic quicklist of a launcher icon contains a Dbusmenu Menuitem with property MENUITEM_PROP_VISIBLE set to False, then Unity crashes when the launcher icon is right-clicked.

For some reason apport wasn't trapping the crashes and there were no crash files in /var/crash for this crash, so I backtraced manually using gdb. Attached is the entire gdb session file.

TEST CASE (for SRU): 1) Download and run this bug's attachment titled 'Unity crash test case script' in a terminal, when GNOME Terminal is running (important).
2) Right-click the gnome-terminal icon in Unity's launcher.
3) Unity crashes. With the fix in -proposed, Unity doesn't crash, and displays only "Item 1" in the upper part of the quicklist, which is the intended behavior.

Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :
Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

For reference, this is the code which I used to create the crash:
https://code.launchpad.net/~bilalakhtar/update-manager/unity-quicklist/+merge/57289

I am actually working on update-manager support for dynamic quicklists, and I need to hide the 'Install all updates' button when there are no updates. If I do that and then right-click update-manager in launcher, Unity crashes.

Alex Launi (alexlauni)
Changed in unity:
status: New → Confirmed
Changed in unity (Ubuntu):
status: New → Confirmed
Changed in unity:
importance: Undecided → Medium
Changed in unity (Ubuntu):
importance: Undecided → Medium
Changed in unity:
assignee: nobody → Mirco Müller (macslow)
Changed in unity:
assignee: Mirco Müller (macslow) → Bilal Akhtar (bilalakhtar)
Changed in unity (Ubuntu):
assignee: nobody → Bilal Akhtar (bilalakhtar)
Changed in unity:
status: Confirmed → In Progress
Changed in unity (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

Fixed in linked branch.

Didier Roche (didrocks)
Changed in unity:
milestone: none → 3.8.14
Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

This Python script demonstrates the problem. Run it like this (also added to bug description):

1) Download and run script from gnome-terminal (important).

2) When script is running, right-click gnome-terminal icon in Unity launcher.

Unity crashes. With the fix in branch, Unity doesn't crash and displays just "Item 1" in the dynamic part of the quicklist, which is the intended behavior in the case of this script.

description: updated
description: updated
Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

Fixed the script a bit.

Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

Fixed in trunk.

Changed in unity:
status: In Progress → Fix Committed
Changed in unity (Ubuntu):
status: In Progress → Fix Committed
Didier Roche (didrocks)
Changed in unity:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 3.8.14-0ubuntu1

---------------
unity (3.8.14-0ubuntu1) oneiric; urgency=low

  * New upstream bug-fix release.
    - In a dual monitor setup with different resolutions, Unity places windows
      in the "dead zone" (LP: #752098)
    - Left pixel of launcher is not clickable on session start (LP: #758026)
    - unity crashed with AttributeError in reset_unity_compiz_profile(): 'str'
      object has no attribute 'get_string' (LP: #737320)
    - unity --reset crashes with NameError (LP: #774280)
    - Bottom icon on launcher tilts when it maybe shouldn't if icons fill
      launcher nearly exactly (LP: #728949)
    - Dodge active window - launcher should not show when modal dialog is
      opened (LP: #718185)
    - Unity maximizes windows that don't support resize on launch (LP: #769781)
    - compiz crashed with SIGSEGV in sigc::signal_base::impl() (LP: #762801)
    - inactive menus becomes brighter on sub-sequent clicks (LP: #733740)
    - Unity crashes when dynamic quicklist dbusmenu contains a hidden menuitem.
      (LP: #759174)
    - Opening quicklist with launcher keynav returns focus to previous window
      (LP: #750781)
    - window's title does not fade in the right position (LP: #722178)
  * debian/control:
    - depends on compiz for some people upgrading (LP: #773253)
  * debian/patches/01_add_scp_to_systray.patch:
    - remove, upstream now
 -- Didier Roche <email address hidden> Thu, 26 May 2011 17:41:14 +0200

Changed in unity (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Accepted unity into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in unity (Ubuntu Natty):
status: New → Fix Committed
tags: added: verification-needed
description: updated
Revision history for this message
Pedro Villavicencio (pedro) wrote :

I've followed the test case and can confirm that the crash is fixed with the proposed version, marking this as verification-done, thanks all.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 3.8.14-0ubuntu1~natty1

---------------
unity (3.8.14-0ubuntu1~natty1) natty-proposed; urgency=low

  * New upstream bug-fix release.
    - In a dual monitor setup with different resolutions, Unity places windows
      in the "dead zone" (LP: #752098)
    - Left pixel of launcher is not clickable on session start (LP: #758026)
    - unity crashed with AttributeError in reset_unity_compiz_profile(): 'str'
      object has no attribute 'get_string' (LP: #737320)
    - unity --reset crashes with NameError (LP: #774280)
    - Bottom icon on launcher tilts when it maybe shouldn't if icons fill
      launcher nearly exactly (LP: #728949)
    - Dodge active window - launcher should not show when modal dialog is
      opened (LP: #718185)
    - Unity maximizes windows that don't support resize on launch (LP: #769781)
    - compiz crashed with SIGSEGV in sigc::signal_base::impl() (LP: #762801)
    - inactive menus becomes brighter on sub-sequent clicks (LP: #733740)
    - Unity crashes when dynamic quicklist dbusmenu contains a hidden menuitem.
      (LP: #759174)
    - Opening quicklist with launcher keynav returns focus to previous window
      (LP: #750781)
    - window's title does not fade in the right position (LP: #722178)
  * debian/control:
    - depends on compiz for some people upgrading (LP: #773253)
  * debian/patches/01_add_scp_to_systray.patch:
    - remove, upstream now
 -- Didier Roche <email address hidden> Thu, 26 May 2011 17:41:14 +0200

Changed in unity (Ubuntu Natty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers