Comment 3 for bug 683466

Revision history for this message
Stefano Candori (cando) wrote :

@Dylan @Mark
After your considerations I've re-looked to my patch and I'm convinced it's written properly ( and DBO too... :) ). I'll try to explain briefly:
1) There are no translation problems because the "Quit" name that I compare it's not the displayed label but only the key of a dictionary ( where the keys are "Launch", "Open in a new window" and "Quit" and the values are the respective Dbusmenuitem objects). In my patch i compare only the labels of these Dbusmenuitems that are already translated.

2) Mark, the patch does exactly what you suggest: if the app has "a gracius way to kill itself" we show its Quit entry, otherwise we show our Unity Quit, that does what is necessary( and if it doesn't it's not related to this bug).

Hoping you've understood, I'm here for any other clarification.

Stefano