FavoriteStore external change support
Bug #681503 reported by
Neil J. Patel
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
High
|
Andrea Azzarone | ||
unity (Ubuntu) |
Fix Released
|
High
|
Andrea Azzarone |
Bug Description
- Favorite store should react to external entities changing the favorites key and emit the correct added/removed/
- Will need to "diff" the current list and the new list
- Tests should include cases where the entire list has changed, or something has been added as well as the list being re-ordered (in additon to normal testing of individual changes)
Related branches
lp:~azzar1/unity/fix-681503
- Mirco Müller (community): Approve
-
Diff: 1285 lines (+1033/-26)13 files modifiedplugins/unityshell/src/BamfLauncherIcon.cpp (+2/-2)
plugins/unityshell/src/BamfLauncherIcon.h (+2/-2)
plugins/unityshell/src/FavoriteStore.h (+5/-5)
plugins/unityshell/src/FavoriteStoreGSettings.cpp (+41/-14)
plugins/unityshell/src/FavoriteStoreGSettings.h (+2/-1)
plugins/unityshell/src/FavoriteStorePrivate.cpp (+130/-0)
plugins/unityshell/src/FavoriteStorePrivate.h (+47/-0)
plugins/unityshell/src/LauncherController.cpp (+85/-0)
plugins/unityshell/src/LauncherModel.cpp (+30/-0)
plugins/unityshell/src/LauncherModel.h (+1/-0)
tests/CMakeLists.txt (+3/-0)
tests/test_favorite_store_gsettings.cpp (+268/-2)
tests/test_favorite_store_private.cpp (+417/-0)
lp:~ubuntu-desktop/unity/ubuntu
(Merged)
Changed in unity: | |
milestone: | 3.2.4 → 3.2.6 |
Changed in unity: | |
milestone: | 3.2.6 → 3.2.8 |
Changed in unity: | |
milestone: | 3.2.8 → 3.4 |
Changed in unity: | |
milestone: | 3.4 → 3.6 |
Changed in unity: | |
milestone: | 3.6 → 3.8 |
Changed in unity (Ubuntu): | |
status: | New → Triaged |
Changed in unity: | |
milestone: | 3.8 → 3.8.2 |
Changed in unity: | |
milestone: | 3.8.2 → 3.8.4 |
Changed in unity: | |
milestone: | 3.8.4 → 3.8.6 |
Changed in unity: | |
milestone: | 3.8.6 → backlog |
Changed in unity: | |
assignee: | Neil J. Patel (njpatel) → Andrea Azzarone (andyrock) |
Changed in unity (Ubuntu): | |
assignee: | nobody → Andrea Azzarone (andyrock) |
description: | updated |
Changed in unity (Ubuntu): | |
importance: | Undecided → High |
Changed in unity: | |
status: | Triaged → In Progress |
Changed in unity (Ubuntu): | |
status: | Triaged → In Progress |
Changed in unity: | |
milestone: | backlog → 5.0.0 |
milestone: | 5.0.0 → backlog |
Changed in unity: | |
milestone: | backlog → 5.0.0 |
Changed in unity: | |
milestone: | 5.0.0 → 5.2.0 |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hi, I'm trying to fix this bug as a bytesize (although it isn't tagged as one).
Although my changes are little (see linked branch), I ran into this problem: once an icon is removed, it cannot be recreated. Any hints?