Update libunity to conform to latest GIO VAPI breakage

Bug #679964 reported by Mikkel Kamstrup Erlandsen on 2010-11-22
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released
Mikkel Kamstrup Erlandsen
unity (Ubuntu)

Bug Description

Due to incompatible changes in the gio-2.0.vapi files libunity no longer builds in unity-io.vala abd unity-appinfo-manager.vala is included in the build. You'll see errors ala:

/home/smspillaz/Source/compiz/compiz-glib/unity/libunity/unity-io.vala:55.48-55.48: error: Argument 2: Cannot convert from `int' to `GLib.ReallocFunc?'
    var output = new MemoryOutputStream (null, 0, realloc, null);
/home/smspillaz/Source/compiz/compiz-glib/unity/libunity/unity-io.vala:59.43-59.48: error: Argument 1: Cannot convert from `void*' to `uint8[]'
        numread = yield input.read_async (buffer, buffer_lenght,
/home/smspillaz/Source/compiz/compiz-glib/unity/libunity/unity-io.vala:65.27-65.32: error: Argument 1: Cannot convert from `void*' to `uint8[]'
        output.write_all (buffer, numread, out numwritten, null);

The two components are need by the place daemons, so are in need of fixing.

Related branches

Changed in unity:
milestone: none → 3.2
assignee: nobody → Mikkel Kamstrup Erlandsen (kamstrup)
importance: Undecided → High
milestone: 3.2 → none
status: New → In Progress
milestone: none → 3.2

Before merging the attach branch I'd like us to dig the old AppInfoManager unit tests out of the bzr history as currently I have no way to test this branch.

Neil J. Patel (njpatel) wrote :

Moving to me temporarily as it's blocked on me enabling the unit tests

Changed in unity:
assignee: Mikkel Kamstrup Erlandsen (kamstrup) → Neil J. Patel (njpatel)
milestone: 3.2 → 3.2.2
Neil J. Patel (njpatel) wrote :

Added support for vala tests on linked branch.

Changed in unity:
assignee: Neil J. Patel (njpatel) → Mikkel Kamstrup Erlandsen (kamstrup)
Neil J. Patel (njpatel) on 2010-11-30
Changed in unity:
milestone: 3.2.2 → 3.2.4
Neil J. Patel (njpatel) on 2010-12-09
Changed in unity:
milestone: 3.2.4 → 3.2.8

I merged Neil's branch, lp:~unity-team/unity/enable-vala-tests, into my own lp:~kamstrup/unity/gio-vapi-break-fixes. It still doesn't build cleanly and the tests needs to be updated to reflect the new api.

David Barth (dbarth) on 2011-01-03
Changed in unity:
milestone: 3.2.8 → 3.2.12

lp:~kamstrup/unity/gio-vapi-break-fixes was merged into lp:unity just before Christmas

Changed in unity:
status: In Progress → Fix Committed
Didier Roche (didrocks) on 2011-01-14
Changed in unity:
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 3.2.12-0ubuntu1

unity (3.2.12-0ubuntu1) natty; urgency=low

  * New upstream release.
   - Window border doesn't get restored (LP: #691812)
   - When a menu is triggered from Alt+key, app name stays visible on panel
     (LP: #691765)
   - show the launcher on <Super> KeyPress, this will be needed when the
     shortcut will be implemented if we are in intellihide mode
   - Make sure an underscore is correctly placed under the corresponding
     accelerator-key. (LP: #683427)
   - Adding a dummy --replace option for compatibility reason (LP: #692569)
   - Compiz crashed with SIGSEGV in CompWindow::id() (LP: #694945)
   - Tooltip text not vertically centered (LP: #697791)
   - Maximizing a window horizontally or vertically removes the title bar
     (LP: #696780)
   - Mousewheel support for indicators (LP: #681428)
   - Avoid Quicklists being positioned so that they are partially offscreen at
     the bottom screen-edge. (LP: #691114)
   - Migrate awn, docky and cairo-dock dock launchers (LP: #692967)
   - Include manpages, and make them translatable. (LP: #684896)
   - Automaximize windows in Unity with some rules like blacklisting some
     applications, initial window size.
     It fixes also some bugs, like maximized window on first map not
     undecorated (LP: #667009, #669716, #693779, #691741)
   - Update libunity to conform to latest GIO VAPI breakage (LP: #679964)
   - Initial unity-atk module implementation (LP: #701680)
   - Panel autohide when on Quicklist (LP: #683261)
  * debian/control:
    - unity breaks on older bamf version (dbus protocol changed)
    - needs latest and greatest from dee
    - add libatk1.0-dev build-dep
  * CMakeList:
    - distro-patch to avoid building tests right now as building them is failing
      with the current vala/gir stack. THIS NEED TO BE REMOVED.
  * debian/rules:
    - don't --fail-missing as we don't want to install the vapi yet. The gir
      package will come next week.
  * debian/unity-common.install:
    - install the manpages
  * debian/libunity3.symbols:
    - updated
 -- Didier Roche <email address hidden> Fri, 14 Jan 2011 20:47:25 +0100

Changed in unity (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers