Comment 0 for bug 1180790

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

==29781== Invalid read of size 1
==29781== at 0x8056C47: g_type_check_instance_cast (gtype.c:4033)
==29781== by 0x16DFC154: unity::launcher::LauncherIcon::TextureFromSpecificGtkTheme(_GtkIconTheme*, std::string const&, int, bool, bool) (LauncherIcon.cpp:432)
==29781== by 0x16DFC450: unity::launcher::LauncherIcon::TextureFromGtkTheme(std::string, int, bool) (LauncherIcon.cpp:379)
==29781== by 0x16E12998: unity::launcher::SimpleLauncherIcon::GetTextureForSize(int) (SimpleLauncherIcon.cpp:108)
==29781== by 0x16F0568F: unity::ui::IconRenderer::RenderIcon(nux::GraphicsEngine&, unity::ui::RenderArg const&, nux::Rect const&, nux::Rect const&) (IconRenderer.cpp:446)
==29781== by 0x16DD9D89: unity::launcher::Launcher::DrawContent(nux::GraphicsEngine&, bool) (Launcher.cpp:1871)
==29781== by 0x18754831: nux::View::ProcessDraw(nux::GraphicsEngine&, bool) (View.cpp:253)
==29781== by 0x1873820C: nux::Layout::ProcessDraw(nux::GraphicsEngine&, bool) (Layout.cpp:581)
==29781== by 0x18713BB7: nux::BaseWindow::DrawContent(nux::GraphicsEngine&, bool) (BaseWindow.cpp:142)
==29781== by 0x18754831: nux::View::ProcessDraw(nux::GraphicsEngine&, bool) (View.cpp:253)
==29781== by 0x18758386: nux::WindowCompositor::RenderTopViewContent(nux::BaseWindow*, bool) (WindowCompositor.cpp:1553)
==29781== by 0x1875F8EE: nux::WindowCompositor::RenderTopViews(bool, std::list<nux::ObjectWeakPtr<nux::BaseWindow>, std::allocator<nux::ObjectWeakPtr<nux::BaseWindow> > >&, bool) (WindowCompositor.cpp:1654)
==29781== Address 0x6168732f72737542 is not stack'd, malloc'd or (recently) free'd
==29781==
==29781==
==29781== Process terminating with default action of signal 11 (SIGSEGV)
==29781== General Protection Fault
==29781== at 0x8056C47: g_type_check_instance_cast (gtype.c:4033)
==29781== by 0x16DFC154: unity::launcher::LauncherIcon::TextureFromSpecificGtkTheme(_GtkIconTheme*, std::string const&, int, bool, bool) (LauncherIcon.cpp:432)
==29781== by 0x16DFC450: unity::launcher::LauncherIcon::TextureFromGtkTheme(std::string, int, bool) (LauncherIcon.cpp:379)
==29781== by 0x16E12998: unity::launcher::SimpleLauncherIcon::GetTextureForSize(int) (SimpleLauncherIcon.cpp:108)
==29781== by 0x16F0568F: unity::ui::IconRenderer::RenderIcon(nux::GraphicsEngine&, unity::ui::RenderArg const&, nux::Rect const&, nux::Rect const&) (IconRenderer.cpp:446)
==29781== by 0x16DD9D89: unity::launcher::Launcher::DrawContent(nux::GraphicsEngine&, bool) (Launcher.cpp:1871)
==29781== by 0x18754831: nux::View::ProcessDraw(nux::GraphicsEngine&, bool) (View.cpp:253)
==29781== by 0x1873820C: nux::Layout::ProcessDraw(nux::GraphicsEngine&, bool) (Layout.cpp:581)
==29781== by 0x18713BB7: nux::BaseWindow::DrawContent(nux::GraphicsEngine&, bool) (BaseWindow.cpp:142)
==29781== by 0x18754831: nux::View::ProcessDraw(nux::GraphicsEngine&, bool) (View.cpp:253)
==29781== by 0x18758386: nux::WindowCompositor::RenderTopViewContent(nux::BaseWindow*, bool) (WindowCompositor.cpp:1553)
==29781== by 0x1875F8EE: nux::WindowCompositor::RenderTopViews(bool, std::list<nux::ObjectWeakPtr<nux::BaseWindow>, std::allocator<nux::ObjectWeakPtr<nux::BaseWindow> > >&, bool) (WindowCompositor.cpp:1654)

GtkIconInfo *info isn't initialized to NULL on line 401 and gets checked for null later.