Comment 2 for bug 1194867

Here are the files I found that have GPL instead of LGPL:

IniParser.h, IniParser.cpp, ExceptionImplBase.cpp, IniParser_test.cpp. We can fix those easily enough.

check_whitespace.py and check_copyright.py are both LGPL.

Apart from the four files above, I believe everything is LGPLv3.

The problem appears to be licensecheck. It fails to recognize check_whitespace.py as having a copyright notice, for example.

Specifically, it fails to detect the following as LGPLv3:

#
# Copyright (C) 2013 Canonical Ltd
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the Lesser GNU General Public License version 3 as
# published by the Free Software Foundation.

If I change "Lesser GNU General Public License" to "GNU Lesser General Public License", it correctly detects LGPLv3.

The problem is that legal told me to use "Lesser GNU General Public License". Apparently, that's wrong because the license text itself uses "GNU Lesser General Public License".

So, how about I go through and change all occurences of "Lesser GNU" to "GNU Lesser"? That should make licensecheck happy. I'll also fix the four files with the wrong license.

This would put all of the source under LGPLv3. As to COPYING.LIB vs COPYING, I couldn't care less what the file is called. It hardly would matter what the file name is, would it? I would have thought that the content is what counts? At any rate, I'm happy to rename it to anything I'm told it should be.

Finally, making licensecheck more robust would be good too. It really should report both wordings correctly.