UIFe: Panel - Indicators should be orderable regardless of their parent IndicatorObject
Bug #823061 reported by
Marco Trevisan (Treviño)
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
High
|
Marco Trevisan (Treviño) | ||
unity-2d |
Fix Released
|
Undecided
|
Marco Trevisan (Treviño) | ||
unity (Ubuntu) |
Fix Released
|
Undecided
|
Marco Trevisan (Treviño) | ||
unity-2d (Ubuntu) |
Fix Released
|
Undecided
|
Marco Trevisan (Treviño) |
Bug Description
According to this design wiki [1] the indicators should be ordered regardless of their parent indicator position, and should be possible to mix app-indicators and other system indicators.
Basically it should be possible to show the nm-applet indicator inside the set of the system indicators, also if it's an app-indicator. Also, we could provide a way for users to define their custom indicators order.
[1] https:/
UIFe: This changes the ordering of the indicators to match the design, however it does *not* change any strings, so translations are not effected.
Related branches
lp:~3v1n0/unity/indicators-redesign
- Florian Boucault (community): Approve
- Neil J. Patel (community): Approve
-
Diff: 2704 lines (+927/-481)24 files modifiedUnityCore/DBusIndicators.cpp (+49/-32)
UnityCore/Indicator.cpp (+55/-37)
UnityCore/Indicator.h (+7/-3)
UnityCore/IndicatorEntry.cpp (+55/-2)
UnityCore/IndicatorEntry.h (+14/-2)
UnityCore/Indicators.cpp (+58/-10)
UnityCore/Indicators.h (+7/-1)
plugins/unityshell/src/PanelIndicatorEntryView.cpp (+42/-33)
plugins/unityshell/src/PanelIndicatorEntryView.h (+7/-6)
plugins/unityshell/src/PanelIndicatorsView.cpp (+164/-87)
plugins/unityshell/src/PanelIndicatorsView.h (+33/-27)
plugins/unityshell/src/PanelMenuView.cpp (+14/-24)
plugins/unityshell/src/PanelMenuView.h (+6/-8)
plugins/unityshell/src/PanelTray.cpp (+8/-8)
plugins/unityshell/src/PanelTray.h (+3/-6)
plugins/unityshell/src/PanelView.cpp (+60/-53)
plugins/unityshell/src/PanelView.h (+6/-4)
services/panel-main.c (+23/-6)
services/panel-root-accessible.c (+1/-1)
services/panel-service.c (+278/-107)
services/panel-service.h (+6/-1)
tests/CMakeLists.txt (+4/-4)
tests/test_indicator_entry.cpp (+20/-16)
tests/unit/TestPanelService.cpp (+7/-3)
lp:~3v1n0/unity-2d/unity-core-indicators-revisited
- Florian Boucault: Pending requested
-
Diff: 201 lines (+84/-11)6 files modifiedlibunity-2d-private/src/indicatorswidget.cpp (+26/-3)
libunity-2d-private/src/indicatorswidget.h (+6/-1)
panel/applets/appname/menubarwidget.cpp (+26/-2)
panel/applets/appname/menubarwidget.h (+6/-0)
panel/applets/indicator/indicatorapplet.cpp (+19/-5)
panel/applets/indicator/indicatorapplet.h (+1/-0)
lp:~ubuntu-desktop/unity/ubuntu
(Merged)
Changed in unity: | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
status: | New → In Progress |
Changed in unity-2d: | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
status: | New → In Progress |
Changed in unity-2d (Ubuntu): | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
Changed in unity (Ubuntu): | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
Changed in unity-2d (Ubuntu): | |
status: | New → In Progress |
Changed in unity (Ubuntu): | |
status: | New → In Progress |
Changed in unity: | |
milestone: | none → 4.14.0 |
importance: | Undecided → High |
status: | In Progress → Fix Committed |
Changed in unity (Ubuntu): | |
status: | In Progress → Fix Committed |
summary: |
- Indicators should be orderable regardless of their parent + UIFe: Panel - Indicators should be orderable regardless of their parent IndicatorObject |
description: | updated |
Changed in unity-2d: | |
status: | In Progress → Fix Committed |
status: | Fix Committed → Fix Released |
Changed in unity-2d (Ubuntu): | |
status: | In Progress → Fix Committed |
status: | Fix Committed → Fix Released |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in unity-2d: | |
status: | Fix Released → Fix Committed |
Changed in unity-2d: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
TBH, I'm not convinced that this feature is important enough to land now (and we have worse itches to scratch than spending development time on this right now).
Documentation team, how many screenshots (roughly) do we have which shows indicators? Do we have translated screenshots? We'd need to replace them all if this would land. Do you have an opinion about this request?