Comment 10 for bug 1622227

Revision history for this message
doniks (kaabud-lp) wrote :

I could test a click, but indeed if it's just two lines, editing is easier for me.

I have tried by adding the two "max lines" (and restoring the two "min lines" I had commented out). I don't think this is what you want to do. See below my testing steps with numbered screenshots.

1. switch to window mode and make the window as small as I can.

2. Turn into landscape mode - now approximately the bottom third of the window is outside of the screen

3. make the window as large as I can. It is now not possible anymore to stretch to the full width of the screen in landscape. It seems that Screen.width relates to the "native" orientation of portrait. NB: See in the background, how I made the Apps scope almost twice as wide as the landscape screen - it seems that no maximum is imposed there

4. turn into landscape. now the bottom little bit of the window can't be shown on the screen because I cannot move the window above the indicator bar.

then I have taken out the "max lines" again and put back
minimumWidth: units.gu(40)
minimumHeight: units.gu(40)

5. that's how 40*40 looks like on the nexus 7 (7 inch screen), the window is approximately four fingertips wide. If I make is smaller some of the screen controls (zoom buttons, settings button) start to fall off the window. One /could/ still make it a little less high, but below, say 40*30 the scrolling in the settings window becomes awkward.

So, my vote would be min=40*40, no maximum.