Comment 3 for bug 660020

Revision history for this message
Martin Pitt (pitti) wrote :

Hello!

Sorry, I didn't see this patch in time. I do like the idea of being able to specify a custom --mount command, if the builtin list doesn't suffice. However, I don't buy the usefulness of --unmount. At the time when this is called, the entire device already went away, so there's little you can do about the device/mount still. What's your use case here?

However, this patch is quite hard to review and apply, as the patch makes a lot of unnecessary whitespace changes. Perhaps you can clean it up a little in that regard?

Perhaps you can re-do this to only add the --mount option, and I'll get that in separately?

Thanks!