Comment on attachment 617270 Fix offline handling in _uploaderCallback
self doesn't seem to be used here either:
+ aOptions = this._overrideDefault(kDefaultReturnHeader, aOptions); + let self = this;
or
+ let subjectString = Cc["@mozilla.org/supports-string;1"] + .createInstance(Ci.nsISupportsString); + subjectString.data = aString;
but other than that and the previous comment, this looks OK. The failure to upload large files worries me, so we should figure that out.
Comment on attachment 617270
Fix offline handling in _uploaderCallback
self doesn't seem to be used here either:
+ aOptions = this._overrideD efault( kDefaultReturnH eader, aOptions);
+ let self = this;
or
+ let subjectString = Cc["@mozilla. org/supports- string; 1"] (Ci.nsISupports String) ;
+ .createInstance
+ subjectString.data = aString;
but other than that and the previous comment, this looks OK. The failure to upload large files worries me, so we should figure that out.