Spacing around banner image

Bug #739538 reported by dobey
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu One Control Panel
Fix Released
Medium
Natalia Bidart
ubuntuone-control-panel (Ubuntu)
Fix Released
Medium
Natalia Bidart

Bug Description

The banner image should have some padding around it, perhaps 6 px of padding. It looks a bit odd being against the edge of the window as it is now.

Related branches

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Hi Daniel,

I'm assigning this bug to you so you can discuss it with Ivanka. If we want to make this change, we should hurry and land a branch today or tomorrow (to make the UI freeze).

Thanks!

Changed in ubuntuone-control-panel:
assignee: nobody → Daniel Fore (daniel-p-fore)
Changed in ubuntuone-control-panel:
status: New → Incomplete
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

I've noticed that the welcome page (AKA splash or overview page) still does not have a dark background behind the main banner. I think that when we have that, the visual effect will be such that no border will be needed.

Changed in ubuntuone-control-panel:
status: Incomplete → In Progress
assignee: Daniel Fore (daniel-p-fore) → Naty Bidart (nataliabidart)
importance: Undecided → Medium
Changed in ubuntuone-control-panel (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Naty Bidart (nataliabidart)
Changed in ubuntuone-control-panel:
status: In Progress → Fix Committed
Revision history for this message
Danielle Foré (danrabbit) wrote :

The theming has been committed to lp:light-themes and with the latest control panel nightly the horizontal padding seems to be fixed.

However the vertical padding still seems to not be in place.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-control-panel - 0.9.3-0ubuntu1

---------------
ubuntuone-control-panel (0.9.3-0ubuntu1) natty; urgency=low

  * New upstream release:

    [ Natalia B. Bidart <email address hidden> ]
      - Restoring some EventBoxes to play along with the theming (LP: #738017).
      - Added proper domain setting to the GTK UI (LP: #735957).
      - Added border to the overview panel (LP: #739538).
      - Removed the event box behing the banner image to avoid different
        background colors.
      - Name for notebook's tab-buttons have now a more realistic name, and
        also match those from the theme ("ModeLeft" and "ModeRight").
      - After initial computer adding, the user is redirected to the Services
        tab (LP: #739576).
      - Replaced the AspectFrame for a plain Frame to fix the different width
        issue (LP: #729382).
      - Changed the legend for plugin/extension installs (LP: #732820).
    [ <email address hidden> ]
      - Use the new service.in file in setup.py
      - Added service file template (will need a packaging branch to actually
        install it) (LP: #728722).
      - Make bin/ubuntuone-control-panel-gtk not open a new panel if one is
        already open.
    [ Alejandro J. Cura <email address hidden> ]
      - Simplify the PanelTitle; instead of a Label within an EventBox, it will
        just be a Label (LP: #737336).

  * debian/ubuntuone-control-panel-gtk.install:
    - Added dbus gui service file path so ise installed (LP: #739714).
 -- Natalia Bidart (nessita) <email address hidden> Wed, 23 Mar 2011 13:39:40 -0300

Changed in ubuntuone-control-panel (Ubuntu):
status: Triaged → Fix Released
Changed in ubuntuone-control-panel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers