Syncdaemon executes multiple GetDelta commands in parallel on the same volume
Bug #883252 reported by
Guillermo Gonzalez
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Ubuntu One Client | Status tracked in Trunk | |||||
Stable-3-0 |
Fix Released
|
High
|
Facundo Batista | |||
Trunk |
Fix Released
|
High
|
Facundo Batista | |||
ubuntuone-client (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | |||
Precise |
Fix Released
|
Undecided
|
Unassigned | |||
Quantal |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Sycndaemon is executing GetDelta requests on the same volume in parallel, when it should only execute 1.
On solution is to add a path_lock based on volume path or id to queue the GetDetla's for the same volume and only execute one at a time (following GetDeltas will not be executed as one is already queued/running)
[Test Case]
Without this fix, excessive GetDelta calls for the same Volume ID will appear in the syncdaemon.log under ~/.cache/
restarting syncdaemon, whenever a GetDelta call is made for a volume, it will occur only once for each volume.
[Regression Potential]
Minimal. New unit test included.
Related branches
lp:~facundo/ubuntuone-client/fix-getdelta-repetition
- Alejandro J. Cura (community): Approve
- Curtis Caravone (community): Approve
-
Diff: 36 lines (+15/-0)2 files modifiedtests/syncdaemon/test_action_queue.py (+9/-0)
ubuntuone/syncdaemon/action_queue.py (+6/-0)
lp:~dobey/ubuntuone-client/fix-getdelta-3-0
- Roberto Alsina (community): Approve
-
Diff: 36 lines (+15/-0)2 files modifiedtests/syncdaemon/test_action_queue.py (+9/-0)
ubuntuone/syncdaemon/action_queue.py (+6/-0)
Changed in ubuntuone-client: | |
status: | New → Confirmed |
importance: | Undecided → High |
tags: | added: chicharra chicharra-oneiric |
tags: |
added: chicharra-precise removed: chicharra-oneiric |
Changed in ubuntuone-client (Ubuntu): | |
status: | New → Confirmed |
Changed in ubuntuone-client: | |
status: | Confirmed → Triaged |
Changed in ubuntuone-client (Ubuntu): | |
importance: | Undecided → Medium |
milestone: | none → ubuntu-12.04.1 |
Changed in ubuntuone-client: | |
assignee: | nobody → Facundo Batista (facundo) |
tags: | added: u1-12.04.1 |
tags: | added: foundations+ |
tags: | added: u1-sru |
Changed in ubuntuone-client (Ubuntu Quantal): | |
milestone: | ubuntu-12.04.1 → none |
Changed in ubuntuone-client (Ubuntu Precise): | |
milestone: | none → precise-updates |
description: | updated |
description: | updated |
To post a comment you must log in.
This bug was fixed in the package ubuntuone-client - 3.0.1-0ubuntu1.1
---------------
ubuntuone-client (3.0.1-0ubuntu1.1) quantal; urgency=low
* New upstream release.
- Don't ignore test failures in from main tests suite. (LP: #993574)
- Avoid multiple parallel GetDelta commands on same volume. (LP: #883252)
- Fix small memory leak in folder enabled check. (LP: #981255)
- Don't start syncdaemon with u1sdtool -q if not running. (LP: #907479)
- Avoid having Upload execute before Makefile command. (LP: #978903)
* debian/watch:
- Update watch file to use stable-3-0 series for downloads now
-- Rodney Dawes <email address hidden> Tue, 22 May 2012 13:33:55 -0400