u1sdtool -q starts ubuntuone-syncdaemon if not already running

Bug #907479 reported by Matt Griffin
20
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu One Client
Status tracked in Trunk
Stable-3-0
Fix Released
Undecided
Unassigned
Trunk
Fix Released
Medium
Diego Sarmentero
ubuntuone-client (Ubuntu)
Fix Released
Undecided
Unassigned
Precise
Fix Released
Undecided
Unassigned

Bug Description

[Test Case]
Steps to recreate.

1. verify that syncdaemon is running
2. type 'u1sdtool -q'
3. verify that syncdaemon is not running
4. type 'u1sdtool -q'
5. verify that syncdaemon is still not running

Expected: Do not start syncdaemon. Return some kind of a message that syncdaemon is not running.
Actual: Syncdaemon is started but the opposite message is returned "ubuntuone-syncdaemon stopped."

[Regression Potential]
Minimal. Fix includes unit tests.

Related branches

Changed in ubuntuone-client:
status: New → Triaged
assignee: nobody → Diego Sarmentero (diegosarmentero)
importance: Undecided → High
importance: High → Medium
tags: added: u1-windows
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

I'm not being able to reproduce this bug in Oneiric and Windows7.

Can you please provide more info, or let me know if this is working now and it was fixed in some of the latest releases?

Thanks!

Revision history for this message
Leo Arias (elopio) wrote :

I can't reproduce it either.

Changed in ubuntuone-client:
status: Triaged → Incomplete
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

Reproduced with Roberto's instructions.

Working on this.

Revision history for this message
Leo Arias (elopio) wrote :

Diego, please post the instructions so we can verify the fix once it's released.

thanks.

Changed in ubuntuone-client:
status: Incomplete → In Progress
Changed in ubuntuone-client:
status: In Progress → Triaged
Changed in ubuntuone-client:
status: Triaged → In Progress
Changed in ubuntuone-client:
status: In Progress → Fix Committed
dobey (dobey)
Changed in ubuntuone-client (Ubuntu Precise):
milestone: none → precise-updates
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in ubuntuone-client (Ubuntu Precise):
status: New → Confirmed
Changed in ubuntuone-client (Ubuntu):
status: New → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-client - 3.0.1-0ubuntu1.1

---------------
ubuntuone-client (3.0.1-0ubuntu1.1) quantal; urgency=low

  * New upstream release.
    - Don't ignore test failures in from main tests suite. (LP: #993574)
    - Avoid multiple parallel GetDelta commands on same volume. (LP: #883252)
    - Fix small memory leak in folder enabled check. (LP: #981255)
    - Don't start syncdaemon with u1sdtool -q if not running. (LP: #907479)
    - Avoid having Upload execute before Makefile command. (LP: #978903)
  * debian/watch:
    - Update watch file to use stable-3-0 series for downloads now
 -- Rodney Dawes <email address hidden> Tue, 22 May 2012 13:33:55 -0400

Changed in ubuntuone-client (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Hello! This bug is attached to an upload in the queue for precise-proposed. However, it does not contain the requisite fields for the SRU team to process the upload. Please add them per the process outlined here. To be more succinct, make sure the bug description lists these fields: "Impact, Dev Fix, Stable Fix, Regression Potential, Test case".

https://wiki.ubuntu.com/StableReleaseUpdates#Procedure

The upload will likely not be looked at by the SRU team until these fields are present.

Thank you!

dobey (dobey)
description: updated
summary: - u1sdtool -q should not start syncdaemon when syncdaemon is not running
+ u1sdtool -q starts ubuntuone-syncdaemon if not already running
dobey (dobey)
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Matt, or anyone else affected,

Accepted ubuntuone-client into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in ubuntuone-client (Ubuntu Precise):
status: Confirmed → Fix Committed
tags: added: verification-needed
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

NACK.

ubuntuone-client was updated in precise-updates for the security issue in bug 882062.

This SRU needs to be updated to include the security fix.

Revision history for this message
Rick McBride (rmcbride) wrote :

verified using:

1. verify that syncdaemon is running
2. type 'u1sdtool -q'
3. verify that syncdaemon is not running
4. type 'u1sdtool -q'
5. verify that syncdaemon is still not running

However, not setting verification-done pending release w/ requested fix in above NACK.

description: updated
Revision history for this message
Rick McBride (rmcbride) wrote :

verified using:

1. verify that syncdaemon is running
2. type 'u1sdtool -q'
3. verify that syncdaemon is not running
4. type 'u1sdtool -q'
5. verify that syncdaemon is still not running

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-client - 3.0.1-0ubuntu1.0.1

---------------
ubuntuone-client (3.0.1-0ubuntu1.0.1) precise-proposed; urgency=low

  * New upstream release.
    - Don't ignore test failures in from main tests suite. (LP: #993574)
    - Avoid multiple parallel GetDelta commands on same volume. (LP: #883252)
    - Fix small memory leak in folder enabled check. (LP: #981255)
    - Don't start syncdaemon with u1sdtool -q if not running. (LP: #907479)
    - Avoid having Upload execute before Makefile command. (LP: #978903)
  * debian/watch:
    - Update watch file to use stable-3-0 series for downloads now
 -- Rodney Dawes <email address hidden> Wed, 06 Jun 2012 14:08:37 -0400

Changed in ubuntuone-client (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.