LR is putting non-utf8 paths into SD
Bug #696901 reported by
John Lenton
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu One Client |
Fix Released
|
High
|
Facundo Batista | ||
ubuntuone-client (Ubuntu) |
Fix Released
|
High
|
dobey |
Bug Description
<facundobatista> there's the notification error, but the problem is that LocalRescan is breaking itself by entering invalid paths into SD
<rye> facundobatista, so, if LR hadn't placed that filename to sd then notification would not have broken the SYS_CONNECT_MADE (in the 822226 report), am I correct?
<facundobatista> rye, yes, but most important, LR would be continued ok
Related branches
lp:~facundo/ubuntuone-client/lr-stop-nonutf8
- Facundo Batista (community): Approve
- Natalia Bidart (community): Approve
-
Diff: 117 lines (+66/-6)2 files modifiedtests/syncdaemon/test_localrescan.py (+32/-1)
ubuntuone/syncdaemon/local_rescan.py (+34/-5)
visibility: | public → private |
Changed in ubuntuone-client: | |
status: | New → Confirmed |
importance: | Undecided → High |
assignee: | nobody → Facundo Batista (facundo) |
tags: | added: chicharra chicharra-natty |
tags: |
added: chicharra-oneiric removed: chicharra-natty |
Changed in ubuntuone-client: | |
status: | Confirmed → In Progress |
Changed in ubuntuone-client: | |
status: | In Progress → Fix Committed |
Changed in ubuntuone-client: | |
milestone: | none → 2.0.0 |
Changed in ubuntuone-client (Ubuntu): | |
assignee: | nobody → Rodney Dawes (dobey) |
importance: | Undecided → High |
status: | New → In Progress |
milestone: | none → ubuntu-11.10 |
Changed in ubuntuone-client: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The one that should check if the path is valid is LocalRescan.
It can't be done in the signals processors (that are close to real validation, in the freeze_commit stage).
The reason for this is that if LR finds an invalid path it needs to ignore it; in files there is no problem, but for directories it shouldn't scan that directory later.