[Windows] no watches needed on parent folders
Bug #838111 reported by
Alejandro J. Cura
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu One Client |
Fix Released
|
Critical
|
Manuel de la Peña | ||
ubuntuone-client (Ubuntu) |
Fix Released
|
Critical
|
dobey |
Bug Description
On windows, starting a watch on a folder automatically locks it, so the watches on parent folders that are added on linux are not needed. Those watches on the parents are being troublesome, because on windows watches are recursive, and we keep getting a lot of repeated events, even when writing on the debug logs.
Related branches
lp:~mandel/ubuntuone-client/donot-add-watches-parents
Rejected
for merging
into
lp:ubuntuone-client
- Manuel de la Peña (community): Disapprove
- Natalia Bidart (community): Needs Fixing
- Diego Sarmentero (community): Approve
-
Diff: 110 lines (+48/-4)4 files modifiedtests/syncdaemon/test_localrescan.py (+20/-1)
ubuntuone/platform/__init__.py (+1/-0)
ubuntuone/platform/local_rescan.py (+25/-0)
ubuntuone/syncdaemon/local_rescan.py (+2/-3)
lp:~mandel/ubuntuone-client/eq-add-ancestors-watches
- Alejandro J. Cura (community): Approve
- Roberto Alsina (community): Approve
-
Diff: 368 lines (+177/-40)8 files modifiedtests/platform/linux/test_filesystem_notifications.py (+46/-0)
tests/platform/windows/test_filesystem_notifications.py (+20/-0)
tests/syncdaemon/test_eq_inotify.py (+38/-2)
tests/syncdaemon/test_localrescan.py (+15/-0)
ubuntuone/platform/linux/filesystem_notifications.py (+29/-1)
ubuntuone/platform/windows/filesystem_notifications.py (+8/-0)
ubuntuone/syncdaemon/event_queue.py (+15/-2)
ubuntuone/syncdaemon/local_rescan.py (+6/-35)
Changed in ubuntuone-client: | |
status: | New → In Progress |
Changed in ubuntuone-client: | |
status: | In Progress → Fix Committed |
tags: | added: u1-windows |
Changed in ubuntuone-client: | |
milestone: | none → 2.0.0 |
Changed in ubuntuone-client (Ubuntu): | |
assignee: | nobody → Rodney Dawes (dobey) |
importance: | Undecided → Critical |
status: | New → In Progress |
milestone: | none → ubuntu-11.10 |
Changed in ubuntuone-client: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntuone-client - 2.0.0-0ubuntu1
---------------
ubuntuone-client (2.0.0-0ubuntu1) oneiric; urgency=low
* New upstream release. email_password on Linux (LP: #831043)
- No watches needed on parent folders (LP: #838111)
- Root is always subscribed (LP: #842839)
- Unicode path asserts failing (LP: #845009)
- Local Rescan is putting non-UTF8 paths into syncdaemon (LP: #696901)
- IOError in tritcask metadata (LP: #776386)
- Missinglogin_
- Unsubscribing share and deleting content triggers unlinks (LP: #820353)
- Only make the link if it doesn't exist (LP: #833812)
- Client restarts on SSL connection error (LP: #833388)
- Stop logging sensitive data (LP: #837488)
- Add delay to the hash queue (LP: #838104)
- Crash if no keydir stats for inactive file (LP: #848224)
- Use correct desktop file for launcher progress bar (LP: #851187)
- Folder nesting check is incorrect (LP: #854776)
- Should have a --version switch for u1sdtool (LP: #379841)
* debian/control:
- Update versions of some dependencies to be more correct
- Recommend ubuntuone-installer needed for Unity launcher integration
-- Rodney Dawes <email address hidden> Tue, 27 Sep 2011 11:18:41 -0400