Comment 2 for bug 1664256

Revision history for this message
Jeremy BĂ­cha (jbicha) wrote :

1. debian/changelog should include (LP: #1664256)

Usually new packages have only one changelog entry (because whatever happened before getting into Ubuntu isn't as important) like this:

* Initial release (LP: #1664256)

2. debian/control: The package is uninstallable because it depends on
ubuntukylin-default-settings (>= 1.3.18)
but the latest version in Ubuntu is only 1.3.17.

3. debian/control: Drop ukwm from description because there won't be a UKWM in Ubuntu, right?

4. I get this lintian error:
E: ukui-session-manager: doc-base-file-syntax-error ukui-session-manager:4

https://lintian.debian.org/tags/doc-base-file-syntax-error.html
http://www.chiark.greenend.org.uk/doc/doc-base/doc-base.html/ch-interface.html

Please remove line 4 from ukui-session-manager.doc-base

5. I will probably comment out the peony Recommends for now. Then once peony is in Ubuntu, we can add that back and anyone upgrading ukui-session-manager will automatically get the recommended package installed.

6. I don't consider this a blocker for zesty, but I wonder whether it's possible to do this without needing to fork mate-session-manager. Is the purpose of this package only to enable login to a MATE session with the environment variables set to UKUI? If so, maybe mate-session-manager could just be patched to do that.

Please fix #1-4 and probably #5 too.