commit 984dd8ad6add4523d93c7ce5a666a32233e02e34
Author: Matt Riedemann <email address hidden>
Date: Fri Oct 27 16:03:15 2017 -0400
Validate new image via scheduler during rebuild
During a rebuild we bypass the scheduler because we are
always rebuilding the instance on the same host it's already
on. However, we allow passing a new image during rebuild
and that new image needs to be validated to work with the
instance host by running it through the scheduler filters,
like the ImagePropertiesFilter. Otherwise the new image
could violate constraints placed on the host by the admin.
This change checks to see if there is a new image provided
and if so, modifies the request spec passed to the scheduler
so that the new image is validated all while restricting
the scheduler to still pick the same host that the instance
is running on. If the image is not valid for the host, the
scheduler will raise NoValidHost and the rebuild stops.
A functional test is added to show the recreate of the bug
and that we probably stop the rebuild now in conductor by
calling the scheduler to validate the image.
Reviewed: https:/ /review. openstack. org/519662 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=984dd8ad6ad d4523d93c7ce5a6 66a32233e02e34
Committed: https:/
Submitter: Zuul
Branch: master
commit 984dd8ad6add452 3d93c7ce5a666a3 2233e02e34
Author: Matt Riedemann <email address hidden>
Date: Fri Oct 27 16:03:15 2017 -0400
Validate new image via scheduler during rebuild
During a rebuild we bypass the scheduler because we are Filter. Otherwise the new image
always rebuilding the instance on the same host it's already
on. However, we allow passing a new image during rebuild
and that new image needs to be validated to work with the
instance host by running it through the scheduler filters,
like the ImageProperties
could violate constraints placed on the host by the admin.
This change checks to see if there is a new image provided
and if so, modifies the request spec passed to the scheduler
so that the new image is validated all while restricting
the scheduler to still pick the same host that the instance
is running on. If the image is not valid for the host, the
scheduler will raise NoValidHost and the rebuild stops.
A functional test is added to show the recreate of the bug
and that we probably stop the rebuild now in conductor by
calling the scheduler to validate the image.
Co-Authored-By: Sylvain Bauza <email address hidden>
Closes-Bug: #1664931
Change-Id: I11746d1ea996a0 f18b7c54b4c9c21 df58cc4714b