Comment 20 for bug 1645698

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks Aron, the update seems mostly fine but some small comments

- usually SRUs changes are kept to the minimum, I guess you can argue that the debian/rules change is safe and useful to you but unsure how much the SRU team is going to like that (it's probably fine though but we should at least try to describe the rational in the changelog)

- " * Patches merged upstream and dropped:
    - manager-fix-state-transition-on-resuming-from-sleep.patch"

Why do you comment it in the serie and keep it in source rather than cleaning it out?

- " * Patches restored for which is relevant again:
    - Don-t-block-network.target-on-NetworkManager-wait-on.patch"

Could you give some more rational for this change, in what situation is it useful? Ideally there would be a corresponding launchpad bug

The first points are nitpicks and shouldn't block the update but I think the restore patch need a bit more explanation, then looks fine to upload.

@Jeremy since you sponsored the previous version and were interested in some of the changes from Debian which are included do you maybe want to give the update a try to see if it address the issue you wanted to see fixed and then sponsor the changes?