Comment 4 for bug 1619354

Revision history for this message
Sebastien Bacher (seb128) wrote : Re: [SRU] network-manager-applet

Thanks for the work, some comments:

- your did changes to debian/rules (and to debian/copyright in xenial), those need to be described in the changelog so the SRU team know that they are wanted and not an error

- is bug #1651019 fixed in zesty? SRU rules mandate that it should be fixed in the current serie first, so either we need an upload there or a comment on the bug stating that it's fixed and close the non-distro-specific line on the bug

- those launchpad bugs look like they are fixed in the new version and it might be good to list them in the changelog, it would give some extra testcase and testing for the update
bug #1570738 (or bug #1597151 from e.u.c which seems the same) and bug #776384

The xenial update is a bit less trivial due to the renames but I guess it makes maintainance work either over time so it's worth doing right?