On 23.06.2016 [22:44:17 -0000], Robin Miller wrote:
> Hi Nish,
>
> Just waiting for the package to publish so I can test, but looking at
> the changelog, I am wondering if this contains both the commits in
> comment #3 above, or just the first one?
The second was a patch to the first, so I folded them together. You can
see this in the source package:
> I apologize for the confusion here BTW. I think it started due to me not
> specifying the commit I needed clearly in the initial report. The commit
> you included in 8.0.32-1ubuntu1.1~ppa,
> https://github.com/apache/tomcat80/commit/103cf11c1cdec6edc1bd497e015435c7d309d4a2,
> was not the correct one, but had a similar sounding changelog entry to
> the requested one ('Refactor the JAR and JAR-in-WAR resource handling to
> reduce the memory footprint of the web application. (markt)', vs
> 'Refactor the web application class loader to reduce the impact of JAR
> scanning on the memory footprint of the web application. (markt)').
>
> After double checking with one of our developers who located the source
> of our memory use problem, it is the two commits noted in comment #3
> that we need (the first of which was the one originally requested).
Ok, so you just need the two commits from c#3? And don't need the
initial commit (~ppa1) at all? I'll submit a test build (~ppa3).
On 23.06.2016 [22:44:17 -0000], Robin Miller wrote:
> Hi Nish,
>
> Just waiting for the package to publish so I can test, but looking at
> the changelog, I am wondering if this contains both the commits in
> comment #3 above, or just the first one?
The second was a patch to the first, so I folded them together. You can
see this in the source package:
Description: Backport of 'Refactor class loading so JAR scanning does /bugs.launchpad .net/bugs/ 1593854 /github. com/apache/ tomcat80/ commit/ 3c0177232399bd2 fe5d675c6000dbb 6503e177c2 /github. com/apache/ tomcat80/ commit/ a2fc002c0db8431 b867c00dfbddc21 00c70f71c6
not trigger the caching of the byte[] for every scanned class until the
class is loaded.'
Author: Nishanth Aravamudan <email address hidden>
Bug-Ubuntu: https:/
Origin: upstream,
https:/
Origin: upstream,
https:/
> I apologize for the confusion here BTW. I think it started due to me not 1ubuntu1. 1~ppa, /github. com/apache/ tomcat80/ commit/ 103cf11c1cdec6e dc1bd497e015435 c7d309d4a2,
> specifying the commit I needed clearly in the initial report. The commit
> you included in 8.0.32-
> https:/
> was not the correct one, but had a similar sounding changelog entry to
> the requested one ('Refactor the JAR and JAR-in-WAR resource handling to
> reduce the memory footprint of the web application. (markt)', vs
> 'Refactor the web application class loader to reduce the impact of JAR
> scanning on the memory footprint of the web application. (markt)').
>
> After double checking with one of our developers who located the source
> of our memory use problem, it is the two commits noted in comment #3
> that we need (the first of which was the one originally requested).
Ok, so you just need the two commits from c#3? And don't need the
initial commit (~ppa1) at all? I'll submit a test build (~ppa3).