neutron bash completion helper is not installed

[Felipe Reyes]

[Impact]

Upstream's bash completion helper ( https://github.com/openstack/python-neutronclient/blob/master/tools/neutron.bash_completion ) is not installed.

debian/rules copies neutron.bash_completion file to $(CURDIR)/debian/python-neutronclient-doc/usr/share/bash-completion/completions/neutron , but python-neutronclient-doc package is not defined in debian/control

[Test Case]

* apt install python-neutronclient
* source novarc
* neutron net-<TAB>

Expected result:

The following list of available commands is printed
net-create net-external-list net-gateway-create net-gateway-disconnect net-gateway-show net-ip-availability-list net-list net-show
net-delete net-gateway-connect net-gateway-delete net-gateway-list net-gateway-update net-ip-availability-show net-list-on-dhcp-agent net-update

Actual Result:

Nothing is printed.

[Regression Potential]

This patch does not change the source code, it only installs a new file that currently is being discarded during the building process.

A potential regression is that users who installed the neutron client completion helper manually and when they install this package it will overwrite it, because this is not a configuration file. But even in that case the user shouldn't notice any difference as "neutron <TAB>" will still bring up a list of commands.

Additional note:

About the following autopkgtest failures :

--
Xenial
Regression in autopkgtest for nova (s390x): test log

Zesty
Regression in autopkgtest for magnum (s390x): test log
--

The failures are not related to this change, nova autopkgtest failure is being analyzed at https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1713059

[Other info]
N/A

[Felipe Reyes (freyes)]

Attaching patch for artful

[Felipe Reyes (freyes)]

Once this is fixed in Artful, I'll SRU the fix into Z, Y and X.

[Eric Desrochers (slashd)]

Hi Felipe,

Is this also impacting python-neutronclient in Debian upstream ?

#python-neutronclient | 1:6.0.0-2 | unstable | source, all
debian/rules: install -D -m 0644 tools/neutron.bash_completion $(CURDIR)/debian/python-neutronclient-doc/usr/share/bash-completion/completions/neutron

If yes, before uploading to Artful, could you report the bug and submit the proposal patch to Debian upstream ?

Regards,
Eric

[Simon Quigley (tsimonq2)]

Unsubscribing ~ubuntu-sponsors as this is waiting on a follow-up (as said in comment #4).

[Launchpad Janitor (janitor)]

This bug was fixed in the package python-neutronclient - 1:6.5.0-0ubuntu1.1

---------------
python-neutronclient (1:6.5.0-0ubuntu1.1) artful; urgency=medium

  * d/rules: include neutron bash completion helper in python-neutronclient
    package (LP: #1692334).

 -- Felipe Reyes <email address hidden> Sun, 21 May 2017 11:47:01 -0400

[Eric Desrochers (slashd)]

Sponsored for Xenial and Zesty.

It is now waiting for approval in both upload queues for the package to start building in $RELEASE-proposed for the testing phase.

- Eric

[Łukasz Zemczak (sil2100)]

Hello Felipe, or anyone else affected,

Accepted python-neutronclient into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-neutronclient/1:6.1.0-0ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Łukasz Zemczak (sil2100)]

Hello Felipe, or anyone else affected,

Accepted python-neutronclient into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-neutronclient/1:4.1.1-2ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Felipe Reyes (freyes)]

I'm delaying the verification of this bug until the patch lands in xenial-newton-proposed, so we don't commit the mistake of landing this in xenial (distro) before fixing it in newton (cloud-archive)

[Eric Desrochers (slashd)]

Hi Felipe,

As previously discussed on IRC, note that the pending SRU[1] page is reporting regressions[2] (autopkgtest failure) on s390x architecture.

Could you please verify the buildlog in order to identify why it fails ? and make sure to document the LP bug accordingly in the regression section (if needed).

[1] - https://people.canonical.com/~ubuntu-archive/pending-sru.html

[2] - Regressions

Xenial
Regression in autopkgtest for nova (s390x): test log
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/s390x/n/nova/20170907_153506_c29e5@/log.gz

Zesty
Regression in autopkgtest for magnum (s390x): test log
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-zesty/zesty/s390x/m/magnum/20170910_011517_08aad@/log.gz

Eric

[Felipe Reyes (freyes)]

The failures are not related to this change, nova autopkgtest failure is being analyzed at https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1713059

[Felipe Reyes (freyes)]

root@grand-bluebird:~# neutron net-
net-create net-gateway-connect net-gateway-disconnect net-gateway-update net-list net-update
net-delete net-gateway-create net-gateway-list net-ip-availability-list net-list-on-dhcp-agent
net-external-list net-gateway-delete net-gateway-show net-ip-availability-show net-show
root@grand-bluebird:~# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 16.04.3 LTS
Release: 16.04
Codename: xenial
root@grand-bluebird:~# apt-cache policy python-neutronclient
python-neutronclient:
  Installed: 1:4.1.1-2ubuntu1
  Candidate: 1:4.1.1-2ubuntu1
  Version table:
 *** 1:4.1.1-2ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu xenial-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     1:4.1.1-2 500
        500 http://archive.ubuntu.com/ubuntu xenial/main amd64 Packages

[Felipe Reyes (freyes)]

root@upright-ant:~# apt-cache policy python-neutronclient
python-neutronclient:
  Installed: 1:6.1.0-0ubuntu3
  Candidate: 1:6.1.0-0ubuntu3
  Version table:
 *** 1:6.1.0-0ubuntu3 500
        500 http://archive.ubuntu.com/ubuntu zesty-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     1:6.1.0-0ubuntu2 500
        500 http://archive.ubuntu.com/ubuntu zesty/main amd64 Packages
root@upright-ant:~# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 17.04
Release: 17.04
Codename: zesty
root@upright-ant:~# source novarc
root@upright-ant:~# neutron net-
net-create net-external-list net-ip-availability-show net-list-on-dhcp-agent net-update
net-delete net-ip-availability-list net-list net-show
root@upright-ant:~# neutron net-list
neutron CLI is deprecated and will be removed in the future. Use openstack CLI instead.
+--------------------------------------+------------------+--------------------------------------------------+
| id | name | subnets |
+--------------------------------------+------------------+--------------------------------------------------+
| 95c71e95-90f9-482c-a855-bff324d6dd7b | freyes_admin_net | 3d9e5ebf-ab16-4b73-bc81-07ab4a8021d5 10.5.0.0/16 |
| fee1396f-5fbf-4dbb-b063-5215be7dc75c | ext_net | 9b3288c6-ea9c-4898-a0db-b0c5394b47e9 |
+--------------------------------------+------------------+--------------------------------------------------+

[Launchpad Janitor (janitor)]

This bug was fixed in the package python-neutronclient - 1:6.1.0-0ubuntu3

---------------
python-neutronclient (1:6.1.0-0ubuntu3) zesty; urgency=medium

  * d/rules: include neutron bash completion helper in python-neutronclient
    package (LP: #1692334).

 -- Felipe Reyes <email address hidden> Mon, 04 Sep 2017 16:07:58 -0300

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for python-neutronclient has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Ryan Beisner (1chb1n)]

The verification of the Stable Release Update for python-neutronclient has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Ryan Beisner (1chb1n)]

This bug was fixed in the package python-neutronclient - 1:6.1.0-0ubuntu3~cloud0
---------------

 python-neutronclient (1:6.1.0-0ubuntu3~cloud0) xenial-ocata; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 python-neutronclient (1:6.1.0-0ubuntu3) zesty; urgency=medium
 .
   * d/rules: include neutron bash completion helper in python-neutronclient
     package (LP: #1692334).

[Eric Desrochers (slashd)]

sil2100, freyes :

I re-ran the autopkgtest this morning against :

"python-neutronclient/1:4.1.1-2ubuntu1" and "nova/2:13.1.4-0ubuntu4.1"
(nova including fixes failing autopkgtests)

and the test that was previously failing, now passes :
http://autopkgtest.ubuntu.com/packages/n/nova/xenial/s390x

- Eric

[Launchpad Janitor (janitor)]

This bug was fixed in the package python-neutronclient - 1:4.1.1-2ubuntu1

---------------
python-neutronclient (1:4.1.1-2ubuntu1) xenial; urgency=medium

  * d/rules: include neutron bash completion helper in python-neutronclient
    package (LP: #1692334).

 -- Felipe Reyes <email address hidden> Mon, 04 Sep 2017 16:13:12 -0300

[Corey Bryant (corey.bryant)]

Hello Felipe, or anyone else affected,

Accepted python-neutronclient into newton-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:newton-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-newton-needed to verification-newton-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-newton-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Corey Bryant (corey.bryant)]

Regression testing was successful for mitaka.

Tempest results for trusty-mitaka-proposed:

======
Totals
======
Ran: 102 tests in 973.8648 sec.
 - Passed: 93
 - Skipped: 9
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 0
Sum of execute time for each test: 542.0364 sec.

Tempest results for xenial-mitaka-proposed:

======
Totals
======
Ran: 102 tests in 965.9171 sec.
 - Passed: 93
 - Skipped: 9
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 0
Sum of execute time for each test: 566.4337 sec.

[Corey Bryant (corey.bryant)]

Regression testing has completed successfully.

xenial-newton proposed with dev charms:

======
Totals
======
Ran: 102 tests in 1453.8196 sec.
 - Passed: 93
 - Skipped: 9
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 0
Sum of execute time for each test: 787.9013 sec.

xenial-newton proposed with stable charms:

======
Totals
======
Ran: 102 tests in 1571.3430 sec.
 - Passed: 93
 - Skipped: 9
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 0
Sum of execute time for each test: 832.8255 sec.

[Corey Bryant (corey.bryant)]

The verification of the Stable Release Update for python-neutronclient has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Corey Bryant (corey.bryant)]

This bug was fixed in the package python-neutronclient - 1:6.0.0-0ubuntu1~cloud1
---------------

 python-neutronclient (1:6.0.0-0ubuntu1~cloud1) xenial-newton; urgency=medium
 .
   * d/rules: include neutron bash completion helper in python-neutronclient
     package (LP: #1692334).

[Corey Bryant (corey.bryant)]

The verification of the Stable Release Update for python-neutronclient has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Corey Bryant (corey.bryant)]

This bug was fixed in the package python-neutronclient - 1:4.1.1-2ubuntu1~cloud0
---------------

 python-neutronclient (1:4.1.1-2ubuntu1~cloud0) trusty-mitaka; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 python-neutronclient (1:4.1.1-2ubuntu1) xenial; urgency=medium
 .
   * d/rules: include neutron bash completion helper in python-neutronclient
     package (LP: #1692334).