DEP8 fixes for xenial
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
libapache2-mod-perl2 (Ubuntu) |
Invalid
|
Low
|
Andreas Hasenack | ||
Xenial |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
The biggest impact of this bug is in future apache2 (and others) SRUs. The libapache2-
Then maybe the SRU team might be convinced to ignore this failure, or ask for a special run with these patches applied showing that the new apache is fixed.
It's unfortunate that to fix a test error we need to push an update out to our users, but I believe in the end this helps them as well, because it's one more test that will be run for future apache2 updates.
[Test Case]
There is a PPA with test packages that can be used until these packages reach proposed. I suggest an autopkgtest run like the following:
autopkgtest -o dep8-xenial-ppa -U -s --apt-pocket=
You will have to adjust the path for the autopkgtest image that you have. If you have none, create one with:
autopkgtest-
That will create a autopkgtest-
[Regression Potential]
This is just test suite update, but new binaries will be produced. If build-depends of libapache2-
[Other Info]
Here is a run with the packages from the aforementioned PPA: http://
== Original Description ==
There are two DEP8 tests that are failing constantly in xenial:
t/apache/read.t
t/filter/
See http://
Debian has fixed them:
libapache2-
* Patch the test suite for Apache 2.4.24 compatibility.
Thanks to Stefan Fritsch. (Closes: #849082)
-- Niko Tyni <email address hidden> Sun, 25 Dec 2016 11:51:10 +0200
This is the diff:
https:/
We should backport these to the xenial package, because libapache2-
Related branches
- Christian Ehrhardt (community): Approve
- Canonical Server: Pending requested
-
Diff: 121 lines (+93/-0)4 files modifieddebian/changelog (+11/-0)
debian/patches/370_http_syntax.patch (+34/-0)
debian/patches/380_inject_header_line_terminators.patch (+46/-0)
debian/patches/series (+2/-0)
I must say that I'm not very fond of autopkgtest-only fixes to stable series, especially for packages that had no updates since release (which is the case here). But in this case I think I'd risk it. The fact that these tests are run for apache2 can be troublesome for regular and security updates (once the autopkgtest are enabled for security).
I would like to request some additional testing if possible, to make sure the new binaries are sane in a regular environment as well. Also, if the package FTBFS or similar, I'll instantly back it off from -proposed.