Comment 7 for bug 1382977

Revision history for this message
In , Evangelos Foutras (foutrelis) wrote :

(In reply to Guido Berhoerster from comment #3)
> Created attachment 5690 [details]
> ensure thunar_file_list_get_applications() has the default application as
> the first element of the returned list
>
> Nice find. Since thunar_file_list_get_applications() and its only consumer
> thunar_launcher_update_idle() are the only places that expect
> g_app_info_get_all_for_type() to have the default application as the first
> element, I don't think it's necessary to expose something like
> thunar_g_app_info_get_all_for_type(). Attached is a slightly revised patch
> that inlines the list reordering into thunar_file_list_get_applications().

I agree that this is the preferred way to fix this. I tested your patch and it works fine (as expected).

Please note that submitting a patch created using 'git format-patch' with proper commit message would ease the job of whoever commits this. It would also include proper credit for your work once it's applied. :)