Comment 40 for bug 1475166

Revision history for this message
kashyap (kashyap-desai) wrote :

@ Bryan - I see what you say... It is bit confusing...you are confuse with max_sectors module parameter. That parameter is only for bit old controllers. See below PnP ID checks in driver code.

/*
  * Check if the module parameter value for max_sectors can be used
  */
 if (max_sectors && max_sectors < instance->max_sectors_per_req)
  instance->max_sectors_per_req = max_sectors;
 else {
  if (max_sectors) {
   if (((instance->pdev->device ==
    PCI_DEVICE_ID_LSI_SAS1078GEN2) ||
    (instance->pdev->device ==
    PCI_DEVICE_ID_LSI_SAS0079GEN2)) &&
    (max_sectors <= MEGASAS_MAX_SECTORS)) {
    instance->max_sectors_per_req = max_sectors;
   } else {
   dev_info(&instance->pdev->dev, "max_sectors should be > 0"
    "and <= %d (or < 1MB for GEN2 controller)\n",
    instance->max_sectors_per_req);
   }
  }
 }

I will be checking how non-PPC environment behaves using same FW component.
 (as per comment #13) 14.10 should work but 15.04 will fail. I will update my findings as well.