Comment 8 for bug 1331452

Revision history for this message
Seth Arnold (seth-arnold) wrote :

Loius, thanks for taking another stab at this, but it still doesn't seem right: cms_smime.c had 37 added lines in the upstream patch, but this includes only three new added lines and no actual functional changes:

+Index: openssl098-0.9.8o/crypto/cms/cms_smime.c
+===================================================================
+--- openssl098-0.9.8o.orig/crypto/cms/cms_smime.c 2014-06-19 09:23:47.888194057 +0200
++++ openssl098-0.9.8o/crypto/cms/cms_smime.c 2014-06-19 09:27:53.552200347 +0200
+@@ -684,7 +684,10 @@
+ STACK_OF(CMS_RecipientInfo) *ris;
+ CMS_RecipientInfo *ri;
+ int i, r;
++ int debug = 0;
+ ris = CMS_get0_RecipientInfos(cms);
++ if (ris)
++ debug = cms->d.envelopedData->encryptedContentInfo->debug;
+ for (i = 0; i < sk_CMS_RecipientInfo_num(ris); i++)
+ {
+ ri = sk_CMS_RecipientInfo_value(ris, i);
diff -Nru openssl098-0.9.8o/debian/patches/CVE-2012-2333.patch openssl098-0.9.8o/debian/patches/CVE-2012-2333.patc

I think it's still missing some important changes.

Thanks