Comment 5 for bug 1936871

Revision history for this message
Daniel Manrique (roadmr) wrote :

Looks like the review-tools-repacked snap has an extra inode. This is the original snap:

Found a valid SQUASHFS 4:0 superblock on /src/click-reviewers-tools/review-tools/jtpboSYvTCEyHoutkkRo1SI9ioSMOUb3_1602.snap.
Creation or last append time Sun Jul 18 16:28:03 2021
Filesystem size 162647053 bytes (158835.01 Kbytes / 155.11 Mbytes)
Compression xz
Block size 131072
Filesystem is exportable via NFS
Inodes are compressed
Data is compressed
Uids/Gids (Id table) are compressed
Fragments are not stored
Xattrs are not stored
Duplicates are removed
Number of fragments 0
Number of inodes 59453
Number of ids 1

This is a repack I did manually. I'm literally compressing the same tree that review-tools would, by stopping the tools before the temp directory is removed:

mksquashfs /tmp/review-tools-r5srrr7b/squashfs-root /tmp/roadpack2.snap -fstime 1626625683 -noappend -comp xz -all-root -no-xattrs -no-fragments
and then -stat says:
Found a valid SQUASHFS 4:0 superblock on /src/click-reviewers-tools/review-tools/jtpboSYvTCEyHoutkkRo1SI9ioSMOUb3_1602.snap.
Creation or last append time Sun Jul 18 16:28:03 2021
Filesystem size 162647053 bytes (158835.01 Kbytes / 155.11 Mbytes)
Compression xz
Block size 131072
Filesystem is exportable via NFS
Inodes are compressed
Data is compressed
Uids/Gids (Id table) are compressed
Fragments are not stored
Xattrs are not stored
Duplicates are removed
Number of fragments 0
Number of inodes 59453
Number of ids 1

And this is the -stat output for the review-tools-repacked snap, note different byte size and number of inodes:

Found a valid SQUASHFS 4:0 superblock on /tmp/review-tools-r5srrr7b/repack.snap.
Creation or last append time Sun Jul 18 16:28:03 2021
Filesystem size 162647101 bytes (158835.06 Kbytes / 155.11 Mbytes)
Compression xz
Block size 131072
Filesystem is exportable via NFS
Inodes are compressed
Data is compressed
Uids/Gids (Id table) are compressed
Fragments are not stored
Xattrs are not stored
Duplicates are removed
Number of fragments 0
Number of inodes 59454
Number of ids 1

Next I'll compare detailed -info output for a tools-driven and an external run.