On 07/10/2015 07:58 AM, Steve Langasek wrote:
> Reviewing the debdiff of the package uploaded to the queue.
> - debian/patches/apport-support.dpatch,
unused ("dpatch"). left over.
> debian/patches/doc-build.diff
needed to build with sphinx 0.5, trusty has 1.2
> debian/patches/installed-testsuite.diff
this just disabled a test, fixed it upstream.
> debian/patches/issue21097.diff
applied upstream
> why have these patches been removed? I find no references to these in the changelog.
> - debian/rules:
> @@ -221,21 +231,22 @@
> stamps/stamp-check stamps/stamp-pystone stamps/stamp-pybench
> touch $@
>
> -PROFILE_EXCLUDES = test_compiler test_distutils test_platform test_subprocess \
> +PROFILE_EXCLUDES = test_compiler test_distutils test_subprocess \
> test_multiprocessing test_socketserver \
> test_thread test_threaded_import test_threadedtempfile \
> test_threading test_threading_local test_threadsignals \
> test_concurrent_futures test_ctypes \
> test_dbm_dumb test_dbm_ndbm test_pydoc test_sundry \
> - test_signal test_ioctl test_gdb
> + test_signal test_ioctl test_gdb test_ensurepip test_venv
> @@ -416,6 +426,7 @@
> endif
> TESTOPTS = -j 1 -w -u$(TEST_RESOURCES)
> TEST_EXCLUDES =
> +TEST_EXCLUDES += test_ensurepip test_venv
> ifeq ($(on_buildd),yes)
> TEST_EXCLUDES += test_tcl test_codecmaps_cn test_codecmaps_hk \
> test_codecmaps_jp test_codecmaps_kr test_codecmaps_tw \
>
> Why are the ensurepip and venv tests being skipped? Considering the
> great deal of work that's been put into ensurepip and venv in this
> version, don't we want this to pass the tests?
this would add build dependencies on all the setuptools and pip packages
currently in universe, because we remove the internal copies in the packages.
these tests just failed in the 3.4.0 packages.
On 07/10/2015 07:58 AM, Steve Langasek wrote: patches/ apport- support. dpatch,
> Reviewing the debdiff of the package uploaded to the queue.
> - debian/
unused ("dpatch"). left over.
> debian/ patches/ doc-build. diff
needed to build with sphinx 0.5, trusty has 1.2
> debian/ patches/ installed- testsuite. diff
this just disabled a test, fixed it upstream.
> debian/ patches/ issue21097. diff
applied upstream
> why have these patches been removed? I find no references to these in the changelog.
> - debian/rules: stamp-pystone stamps/ stamp-pybench ssing test_socketserver \ import test_threadedte mpfile \ local test_threadsignals \ _futures test_ctypes \
> @@ -221,21 +231,22 @@
> stamps/stamp-check stamps/
> touch $@
>
> -PROFILE_EXCLUDES = test_compiler test_distutils test_platform test_subprocess \
> +PROFILE_EXCLUDES = test_compiler test_distutils test_subprocess \
> test_multiproce
> test_thread test_threaded_
> test_threading test_threading_
> test_concurrent
> test_dbm_dumb test_dbm_ndbm test_pydoc test_sundry \
> - test_signal test_ioctl test_gdb
> + test_signal test_ioctl test_gdb test_ensurepip test_venv
> @@ -416,6 +426,7 @@
> endif
> TESTOPTS = -j 1 -w -u$(TEST_RESOURCES)
> TEST_EXCLUDES =
> +TEST_EXCLUDES += test_ensurepip test_venv
> ifeq ($(on_buildd),yes)
> TEST_EXCLUDES += test_tcl test_codecmaps_cn test_codecmaps_hk \
> test_codecmaps_jp test_codecmaps_kr test_codecmaps_tw \
>
> Why are the ensurepip and venv tests being skipped? Considering the
> great deal of work that's been put into ensurepip and venv in this
> version, don't we want this to pass the tests?
this would add build dependencies on all the setuptools and pip packages
currently in universe, because we remove the internal copies in the packages.
these tests just failed in the 3.4.0 packages.