Comment 7 for bug 1313187

Revision history for this message
Seth Arnold (seth-arnold) wrote :

Otto, thanks for this work. Thanks for filing the bug upstream to ask for signed tarballs and thanks for providing this update in near-perfect form.

Our 'umt check' sanity checking tool complained about some missing patch tags:

Patch tagging:
 44_scripts__mysql_config__libs.diff:
   FAIL: neither 'Description' or 'Subject' tagged in patch
   FAIL: Neither 'Origin', 'Author', or 'From' tagged in patch
   WARNING: found old-style '# ' prefix. For 'quilt', don't use '#'.
   (see http://dep.debian.net/deps/dep3/ for details)
 99_remove_rename_mariadb-server_files_in.diff:
   FAIL: neither 'Description' or 'Subject' tagged in patch
   FAIL: Neither 'Origin', 'Author', or 'From' tagged in patch
   WARNING: found old-style '# ' prefix. For 'quilt', don't use '#'.
   (see http://dep.debian.net/deps/dep3/ for details)

Of course this update didn't itself introduce these problems but it would be nice to have them fixed in the future to reduce the number of warnings. See http://dep.debian.net/deps/dep3/ for some information on the DEP-3 patch tagging guidelines.

The locally-built package with your update finished building successfully, and it has even passed many of the tests in our mysql test script that I over-zealously ran sed -i -e 's/mysql/maria/g' on -- the original is here, in case you're curious: http://bazaar.launchpad.net/~ubuntu-bugcontrol/qa-regression-testing/master/view/head:/scripts/test-mysql.py (I had to revert many of the changes and I don't think I've gotten the script quite right yet.) We don't need this script fully functional to release this update but it would be nice to have external smoketests to ensure future updates aren't completely broken.

If the rest of the sanity checks look fine when they finish (waiting on the 'old' package to build locally) then we'll be ready to release this update to users on Monday.

Thanks again.