Comment 0 for bug 1684341

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote : EFI fallback binary should only be installed in removable path

The patch I did to fix names for the new naming of shim binaries included the addition of fbx64.efi; but it was done wrong: fbx64.efi should only exist under \EFI\BOOT, it's not required in the "removable" path; except if we're trying to force installing to the removable path *too*.

In other words:
1) we normally don't want /EFI/ubuntu/fbx64.efi to exist;

and
a) on a desktop or server, we want /EFI/BOOT/fbx64.efi to exist (ie. installs without --removable, and with --force-extra-removable used when grub-install was called);
b) on removable media, we do not want /EFI/BOOT/fbx64.efi to exist (ie. when grub-installed is called with --removable).

Furthermore, the (a) case is probably not the typical case we want to run grub-install with. Calls to grub-install with --force-extra-removable probably should be limited to shim-signed's postinst.

In any case, let's move the fbx64.efi installation step to also_install_removable() in grub-installer to avoid installing it when it shouldn't be.