Hello Samuel, apologies for a delay on the review. Here's a couple of things I suggest you do with the patch before it is uploaded:
1. Please run dch -r and make sure that UNRELEASED now states trusty.
2. In the changelog, please begin all lines with text with a bullet point or sub-bullet point. I would suggest changing the changelog to the following (also contains some wording changes):
* Backport an upstream commit for better TLS 1.2 compatibility during handshakes (LP: #1444656):
- https://gitlab.com/gnutls/gnutls/commit/75b493132239e824d671f4b09d1dfd0f7ca6a8b1
- This fixes a handshake failure on TLS 1.2 connections when one or more
certificates in the chain use the SHA384 or SHA512 signature algorithm.
3. Please add a DEP-3 header. You can do that by running `quilt header --dep3 -e`. More details are available here: http://dep.debian.net/deps/dep3/ .
Once those packaging changes are done, I will be happy to look more at the content of the patch (but in my opinion that's a separate topic, because packaging the backport is different than checking the validity of the backport). As such, I'm unsubscribing ~ubuntu-sponsors. Please feel free to resubscribe ~ubuntu-sponsors once you have an updated patch, and I will promptly review your patch and upload if it looks good.
Thank you for your contribution to Ubuntu and your help in getting this bug fixed!
Hello Samuel, apologies for a delay on the review. Here's a couple of things I suggest you do with the patch before it is uploaded: /gitlab. com/gnutls/ gnutls/ commit/ 75b493132239e82 4d671f4b09d1dfd 0f7ca6a8b1 dep.debian. net/deps/ dep3/ .
1. Please run dch -r and make sure that UNRELEASED now states trusty.
2. In the changelog, please begin all lines with text with a bullet point or sub-bullet point. I would suggest changing the changelog to the following (also contains some wording changes):
* Backport an upstream commit for better TLS 1.2 compatibility during handshakes (LP: #1444656):
- https:/
- This fixes a handshake failure on TLS 1.2 connections when one or more
certificates in the chain use the SHA384 or SHA512 signature algorithm.
3. Please add a DEP-3 header. You can do that by running `quilt header --dep3 -e`. More details are available here: http://
Once those packaging changes are done, I will be happy to look more at the content of the patch (but in my opinion that's a separate topic, because packaging the backport is different than checking the validity of the backport). As such, I'm unsubscribing ~ubuntu-sponsors. Please feel free to resubscribe ~ubuntu-sponsors once you have an updated patch, and I will promptly review your patch and upload if it looks good.
Thank you for your contribution to Ubuntu and your help in getting this bug fixed!