Comment 164 for bug 1040557

Revision history for this message
hanishkvc (hanishkvc) wrote :

Hi Steve/CluedInDevs,

Based on bit more grepping, I think I have part of the answer, at the same time another part still seems to be a potential issue !!! However please do correct my understanding, even if I am fully wrong also.

a) I notice that efivars.c has a pstore logic and using noefi will definitely stop this direct efi variable storage access and possible corruption in Samsung UEFI firmware.

HOWEVER

b) On reading thro the ACPI 4.0a spec, as I had assumed in my last post, it allows the platform provider to use the uefi runtime variable service to store APEI ERST error logging on a UEFI based system.

Now as the apei erst pstore is still registered even if noefi is passed. And inturn has this can inturn trigger writing to efi variable storage during a kernel crash or any apei related writes (Is it used anywhere else, I haven't checked yet), CAN this create any problem either directly (i.e it writing to efi variable storage and triggering the samsung efi bug) or indirectly (i.e as the efi virtual address mapping is not setup when noefi is passed, can it lead to random code running in the system in such a circumstance) ????