Comment 0 for bug 1009200

Revision history for this message
Herton R. Krzesinski (herton) wrote :

Since commit 31db58b3 ("mm: arch: make get_gate_vma take an mm_struct
instead of a task_struct"), that went in linux 2.6.39, get_gate_vma is
expected to take an struct mm_struct pointer as its parameter. But
get_gate_vma in i386 NX emulation code patch is still using the old way,
fix it.

SRU Justification

Impact: seems it could be problems only if acessing something vdso related, not sure, anyway we should fix.

Fix: pass the proper parameter to get_gate_vma

Test Case: without the fix, you get this build warning on i386:
ubuntu-precise/arch/x86/kernel/traps.c: In function 'check_lazy_exec_limit':
ubuntu-precise/arch/x86/kernel/traps.c:145:3: warning: passing argument 1 of 'get_gate_vma' from incompatible pointer type [enabled by default]
ubuntu-precise/include/linux/mm.h:1569:31: note: expected 'struct mm_struct *' but argument is of type 'struct task_struct *'