Comment 12 for bug 2067441

Revision history for this message
James Page (james-page) wrote :

I had a review of the debdiff's attached to this report.

*) Bug References

None of the changelog updates actually reference this bug report - please ensure that the changelog entry details what is being fixed and reference this bug using (LP: #2067441).

*) Patch naming

I'd prefer that we stick with one naming approach for the patches - other SRU uploaders use the lpBUGNUMBER.patch. Either way please don't leave the 0001 prefix from git format-patch in the filename.

1) oracular

This must be fixed in oracular first; the SRU team will quite likely reject an SRU that is not already fixed in development.

2) noble

debdiff uses the version number already consumed in oracular development; you need to follow the version numbering for Stable Release Updates to avoid version conflicts and ensure sequential progression of package versions for upgrades - see [0].

3) mantic is EOL - this update need to target jammy-bobcat directly.

4) antelope(and bobcat)

This debdiffs build directly on the automatically generated backport changelog entry from when these cloud archive series still had an ubuntu parent.

TL;DR the git repositories on Launchpad should be the canonical source for any packaging updates - I can see UNRELEASED changes in both stable/2023.{1,2} which instantly conflict with applying the debdiffs - please can you target merge proposals at the octavia repository [1] on Launchpad instead for all proposed updates:

[0] https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging
[1] https://code.launchpad.net/~ubuntu-openstack-dev/ubuntu/+source/octavia