Hi Jorge and Mauricio, I will sponsor for oracular. The change looks good to me overall, I just have a few notes:
Since the changes to the THANKS and Changelog files are not relevant to the build, and the patch is already a backport due to line number changes, I would recommend removing those portions for better patch compatibility with future updates.
Mauricio also already mentioned changing Origin: upstream to Origin: backport. I can change that too
Last minor note - in the changelog for the lp bug number I'd recommend surrounding with parenthesis for formatting - (LP: #1953572). I've seen some of our automation miss bug numbers in the past without them.
If you would like I can update the debdiff and sponsor, thanks!
Hi Jorge and Mauricio, I will sponsor for oracular. The change looks good to me overall, I just have a few notes:
Since the changes to the THANKS and Changelog files are not relevant to the build, and the patch is already a backport due to line number changes, I would recommend removing those portions for better patch compatibility with future updates.
Mauricio also already mentioned changing Origin: upstream to Origin: backport. I can change that too
Last minor note - in the changelog for the lp bug number I'd recommend surrounding with parenthesis for formatting - (LP: #1953572). I've seen some of our automation miss bug numbers in the past without them.
If you would like I can update the debdiff and sponsor, thanks!