[natty] meld hangs comparing attached files

Bug #774265 reported by Jakob Unterwurzacher
76
This bug affects 17 people
Affects Status Importance Assigned to Milestone
meld (Ubuntu)
Fix Released
Medium
Unassigned
Natty
Fix Released
Medium
Unassigned

Bug Description

Binary package hint: meld

meld 1.5.0-0ubuntu1, i386, Ubuntu Natty.
Upgrading to 1.5.1 from debian experimental solves the problem ( http://packages.debian.org/experimental/meld )

TESTCASE:
extract the attached file.
open them with
> meld mine original

what should happen: meld shows a diff
what happens: meld hangs

regression potential:
low, simple easily backported fix.
release since 1.5.1 in oneiric with no reported regressions.

Related branches

Revision history for this message
Jakob Unterwurzacher (jakobunt) wrote :
Revision history for this message
Julian Taylor (jtaylor) wrote :
tags: added: patch-accepted-upstream
tags: added: natty
Revision history for this message
Charlie Kravetz (cjkgeek) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better. However, I am closing it because the bug has been fixed in the latest development version of Ubuntu - Oneiric Ocelot.

The Natty task should remain open/triaged until the fix is backported to Ubuntu 11.04.

Changed in meld (Ubuntu):
status: New → Fix Released
importance: Undecided → Medium
Julian Taylor (jtaylor)
description: updated
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

SRU request:

Impact: some files may cause meld to hang when parsing them (See attached examples)
Package has been fixed by backporting a specific commit. (See attached minimal debdiff)

Changed in meld (Ubuntu Natty):
status: New → Confirmed
assignee: nobody → Marc Deslauriers (mdeslaur)
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

SRU Team: Please cancel this upload. I've been informed that this is an incomplete fix until bug #786134 gets fixed also.

Changed in meld (Ubuntu Natty):
assignee: Marc Deslauriers (mdeslaur) → nobody
Revision history for this message
Martin Pitt (pitti) wrote :

I rejected the meld upload.

Julian Taylor (jtaylor)
Changed in meld (Ubuntu Natty):
status: Confirmed → Triaged
importance: Undecided → Medium
Julian Taylor (jtaylor)
description: updated
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello Jakob, or anyone else affected,

Accepted meld into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in meld (Ubuntu Natty):
status: Triaged → Fix Committed
tags: added: verification-needed
Svein Seldal (sveinse)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package meld - 1.5.0-0ubuntu1.1

---------------
meld (1.5.0-0ubuntu1.1) natty-proposed; urgency=low

  * debian/patches/fix_iteration.patch
    - Fix hangup when comparing some files (LP: #774265)
  * debian/patches/fix-786134.patch
    - Fix another hangup when comparing some files (LP: #786134)
  * debian/patches/fix-svn-external-crash.patch
    - Fix crash when svn wc contains externals (LP: #787831)
  * debian/patches/fix-vcs-cwd.patch
    - allow opening vcs diff from outside of vcs-dir (LP: #770549)
 -- Julian Taylor <email address hidden> Mon, 22 Aug 2011 13:17:43 +0200

Changed in meld (Ubuntu Natty):
status: Fix Committed → Fix Released
Revision history for this message
Volodia (wojciechblaszczuk) wrote :

regression in ver. 3.16.4-1 ?
it not hangs, but when one of file (in 3-way diff) have no NL on the end - the problem as described here appears: https://bugs.launchpad.net/ubuntu/+source/meld/+bug/829535

Revision history for this message
Balint Reczey (rbalint) wrote :

This does not fail for me in Debian unstable:

echo foo > bar ; echo bar > foo ; echo -n line > nonewline ; meld bar foo nonewline

Do you have a simple test case?

Revision history for this message
Volodia (wojciechblaszczuk) wrote :

ehm... it's stranger - it happens only when conditions:

Cmp files about ~5k lines.
3-way.

- no white line on the end (always 100%)
- then add line are on the end of 1st file on left
  --- then I could remove it and CPU usage is low (1 core btw.)
  --- viewport not on the end of file and cursor outside of viewport (but not repetitive on new instance, much less unresolved diffs was when it not happend...)

I will try debug on my own.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.