squid builds do not halt upon dh_auto_test failures
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
squid (Ubuntu) |
Fix Released
|
Undecided
|
Athos Ribeiro | ||
Jammy |
Fix Released
|
Undecided
|
Athos Ribeiro | ||
Kinetic |
Won't Fix
|
Undecided
|
Athos Ribeiro | ||
Lunar |
Fix Released
|
Undecided
|
Athos Ribeiro |
Bug Description
[ Impact ]
squid builds do not fail when the upstream test suite (ran as part of dh_auto_test) fails.
Running such test suite and ensuring builds will fail when the tests fail will increase confidence in the packaging process and in the health of new packages. This will be specially useful for the MRE test plan being proposed in https:/
[ Test Plan ]
The package build itself should suffice here since it runs the upstream test suite (and will fail if any of the upstream tests fail).
Additionally, one could run a local build removing the change related to using the installed binary for one of the tests, i.e., re-introducing the commented 0003-installed-
[ Where problems could occur ]
The upstream testsuite may fail in different paths for different platforms (this is exactly why we need to disable LTO in s390x here). This could introduce test failures that were not predicted here and prevent the package to build, forcing us to either provide a new fix or revert our changes. To mitigate the matter, we will build the package for the supported platforms in a PPA before uploading the package. We will also run autopkgtests in these platforms to ensure no regressions were introduced, since we are also touching the dep8 test suite here.
Other than that, issues may arise from re-building the package against possible different versions of its dependencies. This would also be an issue for any next SRUs for the package, and we intend to stage this one (block-proposed) since it is a test related only change.
[ Other Info ]
This change was motivated by the discussions in https:/
As requested during the MP review process for this SRU, I am describing the change set applied below:
d/p/0003-
Enabling build failures upon failures in the test suit also triggers LTO related errors in s390x builds. We disable such errors as a workaround.
[ Original message ]
As pointed out in [1], as part of Squid's MRE request [2], squid builds do not fail when the upstream test suite (ran as part of dh_auto_test) fails.
Running such test suite and ensuring builds will fail when the tests fail will increase confidence in the packaging process and in the health of new packages. This will be specially useful for the MRE test plan described in [2].
We want to enable the described behavior in lunar (development) and then SRU it all the way down to focal (which shall also receive MREs in the future).
[1] https:/
[2] https:/
Related branches
- git-ubuntu bot: Approve
- Bryce Harrington (community): Approve
- Canonical Server Reporter: Pending requested
-
Diff: 39 lines (+12/-4)2 files modifieddebian/changelog (+8/-0)
debian/rules (+4/-4)
- git-ubuntu bot: Approve
- Bryce Harrington (community): Approve
- Canonical Server Reporter: Pending requested
-
Diff: 124 lines (+34/-33)5 files modifieddebian/changelog (+14/-0)
debian/patches/series (+0/-1)
debian/rules (+16/-2)
debian/tests/upstream-test-suite (+4/-0)
dev/null (+0/-30)
- git-ubuntu bot: Approve
- Bryce Harrington (community): Approve
- Canonical Server Reporter: Pending requested
-
Diff: 74 lines (+30/-3)4 files modifieddebian/changelog (+13/-0)
debian/patches/series (+3/-1)
debian/rules (+10/-2)
debian/tests/upstream-test-suite (+4/-0)
- Bryce Harrington (community): Needs Fixing
- Canonical Server Reporter: Pending requested
-
Diff: 87 lines (+36/-3)4 files modifieddebian/changelog (+14/-0)
debian/patches/series (+3/-1)
debian/rules (+15/-2)
debian/tests/upstream-test-suite (+4/-0)
- git-ubuntu bot: Approve
- Bryce Harrington (community): Approve
- Canonical Server Reporter: Pending requested
-
Diff: 87 lines (+36/-3)4 files modifieddebian/changelog (+14/-0)
debian/patches/series (+3/-1)
debian/rules (+15/-2)
debian/tests/upstream-test-suite (+4/-0)
CVE References
no longer affects: | squid (Ubuntu Focal) |
description: | updated |
tags: | added: server-todo |
Changed in squid (Ubuntu Lunar): | |
assignee: | nobody → Athos Ribeiro (athos-ribeiro) |
Changed in squid (Ubuntu Kinetic): | |
assignee: | nobody → Athos Ribeiro (athos-ribeiro) |
Changed in squid (Ubuntu Jammy): | |
assignee: | nobody → Athos Ribeiro (athos-ribeiro) |
tags: | added: block-proposed-jammy block-proposed-kinetic |
Changed in squid (Ubuntu Jammy): | |
status: | New → In Progress |
Changed in squid (Ubuntu Kinetic): | |
status: | New → In Progress |
description: | updated |
tags: | removed: server-todo |
tags: |
added: verification-done verification-done-kinetic removed: verification-needed verification-needed-kinetic |
tags: | removed: block-proposed-kinetic |
This bug was fixed in the package squid - 5.7-1ubuntu2
---------------
squid (5.7-1ubuntu2) lunar; urgency=medium
* Make builds fail when upstream test suite fails (LP: #2004050): test-suite: use installed squid binary for
- d/p/series: do not rely on installed binaries for build time tests.
- d/rules: halt build upon test failures.
- d/rules: do not include additional configuration files during
build time tests. This would lead to test failures due to missing
paths.
- d/t/upstream-
autopkgtest config file checks.
- d/rules: disable LTO for s390x builds.
-- Athos Ribeiro <email address hidden> Fri, 27 Jan 2023 11:06:05 -0300