I'm certainly in favor of upstream test suite results being honored at build time. But I am uncomfortable with the change to disable LTO for the s390x *binaries* on account of the *test suite* failing to build when LTO is enabled.
I realize the flags for both the installed executables and the test suite are generated at the same time and it's awkward to disable LTO for just the test suite. Nevertheless, I think a more nuanced approach is warranted here instead of trading off the test suite vs the optimization of the installed binaries.
Does the build succeed if instead of disabling LTO, you pass -Wno-error=stringop-overread, disabling the specific compiler check that seems to be failing here?
I'm certainly in favor of upstream test suite results being honored at build time. But I am uncomfortable with the change to disable LTO for the s390x *binaries* on account of the *test suite* failing to build when LTO is enabled.
I realize the flags for both the installed executables and the test suite are generated at the same time and it's awkward to disable LTO for just the test suite. Nevertheless, I think a more nuanced approach is warranted here instead of trading off the test suite vs the optimization of the installed binaries.
Does the build succeed if instead of disabling LTO, you pass -Wno-error= stringop- overread, disabling the specific compiler check that seems to be failing here?