Comment 0 for bug 2039542

Revision history for this message
Roxana Nicolescu (roxanan) wrote :

SRU Justification:

[Impact]

* Commit 88da4e8113110d5f4ebdd2f8cd0899e300cd1954 "pwm: Add a stub for devm_pwmchip_add()" was applied the second time during the latest upstream patchset (#LP: 2037005). `git am` did not detect the changes were applied, leading to the same function definition being duplicated.
This was not caught when the main kernel was built because this code is under CONFIG_PWM=n. The main kernel and pretty much every kernel apart from kvm, has CONFIG_PWM=y.
The problem was caught when lunar:linux-kvm was cranked and build failed for the current 2023.10.02 cycle

[Fix]
* Revert the commit

[Test plan]
* Since linux-kvm was the only kernel that had this issue, I applied the patch to kvm after I rebased the latest changes from the parent and did a build test.
* I also did a build test for linux:main just to make sure

[Where problems could occur]
* This change is pretty non-invasive, so nowhere