Thanks for the review Sergio! Let me answer each point below:
- d/changelog changes: I understand your point but in my perspective we haven't had a delta compared to Debian so far. I am saying that because src:docker.io has been a fork of the Debian package and diverged completely in the last years, the last Debian upload in the Ubuntu src:docker.io is version 1.11.2~ds1-1 from 8 years ago. Due to that, I believe it is a good idea to start fresh again, and now we are adding a delta on top of what we have in Debian, and keep tracking those change from now on. WDYT?
- uscan issue: You are right, I was also not able to get the upstream tarballs with uscan. Due to that, I am going to use our old d/watch (using tianon's service to avoid some of those issues) for now, but I'd like to investigate this a bit more to make sure we really need this delta in future uploads.
- override_dh_gencontrol in d/rules: Agreed. It is going to be removed.
- docker-doc binary package: Agreed. I moved this binary package to src:docker.io-app and I am going to remove it from src:docker.io.
- d/tests removal: Agreed. The tests are already in src:docker.io-app, I am going to remove them from src:docker.io.
Thanks for the review Sergio! Let me answer each point below:
- d/changelog changes: I understand your point but in my perspective we haven't had a delta compared to Debian so far. I am saying that because src:docker.io has been a fork of the Debian package and diverged completely in the last years, the last Debian upload in the Ubuntu src:docker.io is version 1.11.2~ds1-1 from 8 years ago. Due to that, I believe it is a good idea to start fresh again, and now we are adding a delta on top of what we have in Debian, and keep tracking those change from now on. WDYT?
- uscan issue: You are right, I was also not able to get the upstream tarballs with uscan. Due to that, I am going to use our old d/watch (using tianon's service to avoid some of those issues) for now, but I'd like to investigate this a bit more to make sure we really need this delta in future uploads.
- override_ dh_gencontrol in d/rules: Agreed. It is going to be removed.
- docker-doc binary package: Agreed. I moved this binary package to src:docker.io-app and I am going to remove it from src:docker.io.
- d/tests removal: Agreed. The tests are already in src:docker.io-app, I am going to remove them from src:docker.io.