Comment 76 for bug 581925

Revision history for this message
Martin Pitt (pitti) wrote :

jonie,

there is a regression report at

  http://bugs.archlinux.org/task/20550?string=udev&project=1&type[0]=&sev[0]=&pri[0]=&due[0]=&reported[0]=&cat[0]=&status[0]=open&percent[0]=&opened=&dev=&closed=&duedatefrom=&duedateto=&changedfrom=&changedto=&openedfrom=&openedto=&closedfrom=&closedto=

and http://www.spinics.net/lists/hotplug/msg04145.html . Unfortunately the 161-1 log file was done without a medium in the drive, I'll ask for a proper log.

But while I looked through the code, I noticed a flaw in your "DVD-RW ro/seq" patch (http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=cf2205a1986222fdc0238190f5742f54d943cd23): It inserts the ro/seq differentiation into
feature_profiles(), but this should just detect the drive capabilities, not the medium state. With a DVD-ROM I get

feature_profiles: profile 0x13 media_dvd_rw
feature_profiles: profile 0x14 dvd_rw
[...]
cd_profiles: profile 0x10 media_dvd_ro
[...]
ID_CDROM_MEDIA=1
ID_CDROM_MEDIA_DVD=1
ID_CDROM_MEDIA_DVD_RW=1

I fixed that in http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=2458db3edd8d66827b34978ff471dff8f879e9ab , but I suppose this is not the complete fix for that bug yet. I'll ask for a full log on the ML and keep you posted here.