Comment 1 for bug 504723

approving with some nits; those can be dealt after Main inclusion. Just ensure that the bugs are filed and assigned.

Please file bugs for and fix a couple of compiler warnings:

fat.c: In function 'read_bootsectandvi':
fat.c:707: warning: array subscript is above array bounds

mxc_fec.c: In function 'fec_init':
mxc_fec.c:625: warning: cast from pointer to integer of different size

xyzModem.c: In function 'xyzModem_stream_open':
xyzModem.c:564: warning: 'dummy' is used uninitialized in this function

bmp_logo.c: In function 'main':
bmp_logo.c:71: warning: ignoring return value of 'fread', declared with attribute warn_unused_result

a few more nice to have fixes:

various warnings of type:
   ... warning: function declaration isn't a prototype

also:
  fsl_mmc.c:1154: warning: 'mmc_send_scr' defined but not used
  fsl_mmc.c:1216: warning: 'mmc_read_switch' defined but not used

  imx_spi_nor_atmel.c: In function 'spi_nor_erase_page':
  imx_spi_nor_atmel.c:109: warning: unused variable 'cmd'
  imx_spi_nor_atmel.c: At top level:
  imx_spi_nor_atmel.c:106: warning: 'spi_nor_erase_page' defined but not used

  cmd_flash.c:471: warning: unused variable 'addr_last'
  cmd_flash.c:471: warning: unused variable 'addr_first'