Comment 41 for bug 350936

Reinhard, to answer you questions.
I created the init script first before I ran into this problem
The reason being was 1) to minimize modification of system files and 2) to be able to shutdown guests on non-upstart versions of Linux. and 3) to enable stopping all guests manually without having to stop libvirtd

As far as the section that checks if libvirtd is running. I had and inststance on shutdown where libvirtd was not running
for some reason. and hence it could not stop the guests. Dont know why that was so I stuck that in there just to make sure it is before shutting down the vm. It may not be necessary at this point.

I thought of using the omit feature in the sendsigs script. I tried to test this by manully putting the pids of vms in file called
/lib/init/rw/sendsigs.omit. This did nothing. Maybe I didn't do something correctly there to test this.

Reinhard said: "wouldn't it be less intrusive to make /etc/init/libvirt-bin.conf or probably libvirtd itself
drop or copy the pid files into /lib/init/rw/sendsigs.omit.d? AFAIUI,
the upstart job should be executed before the sendsigs init script, or
is there another race here?"

I agree. If it would work. I think the less intrusive the better actually. having to keep up with modified system files on every 10.04 system i setup can be a drag.