Comment 28 for bug 482419

Revision history for this message
Steve Langasek (vorlon) wrote :

Hi Bhavani,

What dpkg trigger error are you trying to fix? The changes to the maintainer scripts should have no effect on dpkg triggers. In fact, they should have no effect in Ubuntu at all because the change only applies to upgrades from version 1.1.0-6 or before, which is the version that was in dapper. (If a user *does* try to upgrade directly from dapper, then this won't work either, because you use the wrong conffile names in your patch to the preinst). If you believe this is an important change to make in spite of this, please provide a separate bug reference in the changelog; there should be a separate bug report in Launchpad for each issue being fixed in SRU.

As for the pre-up change: why is this function being split into two? The two halves of the function are still being called, in the same order, with nothing else between them, so that seems unnecessary for an SRU? The change appears to be equivalent to this much shorter patch:

@@ -128,2 +131,2 @@
-enslave_slaves
 setup_master
+enslave_slaves

Have I overlooked some reason that we want to split the function?